Problem with backbone.localstorage on some Androids about backbone.localstorage HOT 6 CLOSED

confirming this is a bug as well.

from backbone.localstorage.

Same here. Fix from Sergeyshall resolved the issue for me.

from backbone.localstorage.

Wow, I have no been receiving the email notifications of new issues. I'm sorry if that took a while.

Would you mind submitting a pull request with that code? Maybe even write a test for it :)

from backbone.localstorage.

My two cents - I've come across this problem before too, but my suggested approach would be to duck-punch JSON.parse. This way we don't need to add the same null checks every time we are parsing JSON. Pull Request #41 only fixes the case of JSON.parse within this library - what if I need to do JSON.parse in my own code?

For example:

brianleroux/lawnchair#48 (comment)

from backbone.localstorage.

We've come across this issue as well. In our own code it's trivial to implement a null check like value && JSON.parse(value);. To keep the fixing code separate we added jsonData().

find: function(model) {
  // call to this.jsonData instead of JSON.parse
  return this.jsonData(this.localStorage().getItem(this.name+"-"+model.id));
}

findAll: function() {
  return _(this.records).chain()
    .map(function(id){
      return this.jsonData(this.localStorage().getItem(this.name+"-"+id));
    }, this)
    .compact()
    .value();
}

and as above the actual handling is simple

jsonData: function (data) {
  return data && JSON.parse(data);
}

from backbone.localstorage.

@nerdgore If you'd like to submit that as a pull request, it'd be greatly appreciated.

from backbone.localstorage.