UniqueArguments omitted when serializing a webhook event about stronggrid HOT 6 CLOSED

@elmalakai here's a beta version of the next package that will properly serialize uniqueargs: https://www.myget.org/feed/jericho/package/nuget/StrongGrid/0.101.0-beta0005

The only concession we have to make is that unique arguments with a numerical value will be serialized as a string like so:

"reseller_id": "1234"

which is not 100% same as the original JSON received from SendGrid but it's the best we can do due to the fact that unknown values must be cast as string in order to be added to the Dictionary<string, string>.

from stronggrid.

I struggle with this a lot in dealing with JSON everywhere. Lately I use Dictionary<string,object> and use one of the many System.Text.Json 'generic' object converters out there to store the value as strongly typed (double, bool, null, string, array).

I think for now, treating all unique arguments as strings is acceptable. Most of these arguments you add yourself to the message, so you know best how to parse and deal with them.

from stronggrid.

Thanks for confirming.

from stronggrid.

Looks like you had an bug in 0.101.0-beta0005 but I think you've fixed it. I tried to write a test case for it and it's working. Specifically, the UniqueArguments were being double wrapped in double quotes when deserialized:

? events[0].UniqueArguments["environment"]
"\"Production\""

Tried to write a test case for it, but I think you beat me to it (Webhook_includes_unknow_property).

from stronggrid.

Yes, I confirm there was an issue with quotes being doubled but fixed it here: 04ba8b2#diff-bbf883778fe4acba4cb2d3272c16d800f7dcc6fcbf69c03f9415607d4af110fdR115

Using .GetRawText() to get the content of a JSON node containing a string includes the double quotes evidently (I didn't know). It's not a problem with nodes containing numerical values though.

from stronggrid.

🎉 This issue has been resolved in version 0.101.0 🎉

The release is available on:

• GitHub Release
• NuGet Package

Your GitReleaseManager bot 📦🚀

from stronggrid.