Giter Club home page Giter Club logo

Comments (6)

github-actions avatar github-actions commented on May 27, 2024

Thank you for using this application, please make sure you reviewed the readme and checked that it is not an environmental issue. If it is an urgent security concern, please email [email protected]. Thank you!

from laravel-auth.

jeremykenedy avatar jeremykenedy commented on May 27, 2024

I am unable to replicate

from laravel-auth.

inforisorse avatar inforisorse commented on May 27, 2024

reverted and got screenshot

issue-446

The only difference with default environment is the use of Soketi as pusher service. The fault is due to the $('#confirmSave').on('show.bs.modal', function (e) {...} that is not executed unless wrapped in a $(document).ready() function.

To fix i changed the code in:

<script type="text/javascript"> // CONFIRMATION SAVE MODEL $(document).ready(function() { // <== ensure event is registered $('#confirmSave').on('show.bs.modal', function (e) { var message = $(e.relatedTarget).attr('data-message'); var title = $(e.relatedTarget).attr('data-title'); var form = $(e.relatedTarget).closest('form'); $(this).find('.modal-body p').text(message); $(this).find('.modal-title').text(title); $(this).find('.modal-footer #confirm').data('form', form); }); $('#confirmSave').find('.modal-footer #confirm').on('click', function(){ $(this).data('form').submit(); }); }); </script>

from laravel-auth.

jeremykenedy avatar jeremykenedy commented on May 27, 2024

If you make a PR I will honor it. Thank you 😊

from laravel-auth.

inforisorse avatar inforisorse commented on May 27, 2024

I'm trying to understand how to fork the project and submit PR... I hope i will be able to submit it soon since there are some other issues i'm interested to investigate and some minor improvements i may propose.

from laravel-auth.

Jonnyenglish89 avatar Jonnyenglish89 commented on May 27, 2024

Thank you for sharing this fix. I noticed the same issue in the form-modal-script.blade.php file.
Here's the corrected code:

`<script type="text/javascript">
$(document).ready(function() {
$('#confirmForm').on('show.bs.modal', function (e) {
var modalClass = $(e.relatedTarget).attr('data-modalClass') || '';
var submitText = $(e.relatedTarget).attr('data-submit');
var message = $(e.relatedTarget).attr('data-message');
var title = $(e.relatedTarget).attr('data-title');
var form = $(e.relatedTarget).closest('form');
var self = $(this);

        self.alterClass('modal-*', modalClass);
        self.find('.modal-body p').text(message);
        self.find('.modal-title').text(title);

        self.find('.modal-footer #confirm')
            .text(submitText)
            .data('form', form);
    });
    $('#confirmForm').find('.modal-footer #confirm').on('click', function(){
        $(this).data('form').submit();
    });
});
</script> `

Please review and apply this change to the repository if possible.
Cheers

from laravel-auth.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.