Giter Club home page Giter Club logo

Comments (4)

jeremeamia avatar jeremeamia commented on June 30, 2024

I can't speak for the Laravel documentation, but SuperClosure should handle magic constants just fine. One of the features on the README says, "Replaces magic constants with their expected values so that the closure behaves as expected after unserialization". The two visitor classes help make this possible.

Now, if you've tried it, and it is not working, then I would consider it a bug. Have you tried it, or are you just going off what the Laravel docs say?

Prior to about September last year, Laravel did not use the SuperClosure package (it was using an older, vendored version of SuperClosure). At that point in time, that piece of documentation was probably true. If __DIR__ is working for you, then you should raise an issue with the Laravel docs to have that updated.

from super_closure.

franzliedke avatar franzliedke commented on June 30, 2024

Thanks for the feedback, I'll contact Laravel's developer and will report back to you.

from super_closure.

franzliedke avatar franzliedke commented on June 30, 2024

Looks like it was just an oversight. Thank you, great library by the way!

from super_closure.

franzliedke avatar franzliedke commented on June 30, 2024

Works beautifully, thanks!

from super_closure.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.