More complex unsubscription in v2 about interstellar HOT 5 CLOSED

Hey there! Any update on this? Is it an idea you think is worth pursuing?

from interstellar.

That sounds like a good idea.

But here's another solution for your problem:

class CellHolder {
  weak cell: UITableViewCell
  func doStuffOnCell(value: T) {}
}

class Cell: UITableViewCell {
  var holder: CellHolder?

  func setupCell(observable) {
    observable.subscribe {[weak holder] t: T in
      holder?.doStuffOnCell(t)
    }
  }

  override func prepareForReuse() {
    holder = nil
  }
}

This saves you from the hassle of constantly subscribing/unsubscribing during prepareForReuse and let ARC handle the task for you.

Only drawback: After the cell is dealloced the subscription stays around. I haven't done any performance testing on that yet but I assume it's more performant on the long term.

from interstellar.

Yeah, that's makes sense. In our case, we're going to have a few hundred observables each subscribed to hundreds and hundreds of times, in an app that needs to be remain usable during hours of use (edge case, but it's important). Usually I've followed this example, but in a few instances, I need to unsubscribe from popular observables.

I'll send a PR with a sample implementation, I'd love to get your feedback.

from interstellar.

Thank you! (I'm a quite busy until next Wednesday, so responses might take a bit)

from interstellar.

Unsubscribe has now landed in V2, therefore closing this issue.

from interstellar.