Giter Club home page Giter Club logo

Comments (10)

timja avatar timja commented on August 12, 2024 2

I've had an initial look at this, the flag doesn't do what I expect at all.

It seems to be more about listing installation of plugins rather than a typical list command (which already get logged out anyway).

If no objections I would just completely re-work this to be a standalone flag that only lists installed plugins.

It would be a breaking change but I doubt people are actually using this

from plugin-installation-manager-tool.

oleg-nenashev avatar oleg-nenashev commented on August 12, 2024 2

Working on a fix restoring the option

from plugin-installation-manager-tool.

raspy avatar raspy commented on August 12, 2024 1

Introduced and mentioned in review of #94 .

from plugin-installation-manager-tool.

oleg-nenashev avatar oleg-nenashev commented on August 12, 2024 1

2.4.0+ includes a fix

from plugin-installation-manager-tool.

jetersen avatar jetersen commented on August 12, 2024 1

@pwillis-els you can always see the release notes: https://github.com/jenkinsci/plugin-installation-manager-tool/releases

from plugin-installation-manager-tool.

raspy avatar raspy commented on August 12, 2024

Additional "feature": running the same command twice means downloading everything twice, since everything is deleted before it is considered as being already installed.

from plugin-installation-manager-tool.

timja avatar timja commented on August 12, 2024

@raspy most of what you said isn’t related to this issue.

The code needs to be reworked to not go through the path that deletes the plugins.

Updating the plugins file code is an example of where this should probably be invoked from.

The deleting bit can be reworked too but there’s no need for this code to go through that code path

from plugin-installation-manager-tool.

reinholdfuereder avatar reinholdfuereder commented on August 12, 2024

We just stumbled over this shocking bug as well: kind of "maximum surprise" principle ;-)

from plugin-installation-manager-tool.

reinholdfuereder avatar reinholdfuereder commented on August 12, 2024

@timja Yes, please!

from plugin-installation-manager-tool.

pwillis-els avatar pwillis-els commented on August 12, 2024

@oleg-nenashev is there a PR or branch to track? Mainly I wanted to comment and ask if the new fix will involve an output to be able to diff the versions. Basically I want to use this tool mainly to tell me currently "latest" versions compared to versions in plugins.txt. The use case is to automate a build pipeline to rebuild Jenkins when a new plugin is released, run a series of tests, and if it fails, revert the plugin change and open a new bug (not here!) to investigate the break. (Without "-l" option the tool does not show what the current latest version is if you have unpinned plugins; I know I could script this myself, but would rather use a supported tool if possible)

from plugin-installation-manager-tool.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.