Giter Club home page Giter Club logo

Comments (6)

ozangunalp avatar ozangunalp commented on June 9, 2024

I agree that this test is far from ideal. It should not download the jar etc. I'll look more into the grab configuration. Feel free to suggest a PR to fix it.

Thanks

from jenkinspipelineunit.

sic-bre avatar sic-bre commented on June 9, 2024

Actually there is a much simpler solution, just add it to the testCompile configuration and it passes the unit tests:

Remove from Utils.groovy:
@grab('org.apache.commons:commons-math3:3.4.1')

Add to the top level build.gradle in dependencies {} block:
testCompile group: 'org.apache.commons', name: 'commons-math3', version: '3.4.1'

I'll add a PR if you still want it but this is so simple...

from jenkinspipelineunit.

ozangunalp avatar ozangunalp commented on June 9, 2024

It is there to verify if the Grab is working as expected.
The shared library test can be splitted, that's for sure. But I would not remove it.

from jenkinspipelineunit.

sic-bre avatar sic-bre commented on June 9, 2024

Take a look at the PR I added this afternoon I think it does what you want it to do.

from jenkinspipelineunit.

ozangunalp avatar ozangunalp commented on June 9, 2024

Thanks for the pr. I saw it and it should work as expected but didn't had time to test it yet. I'd prefer doing it on junit though.

from jenkinspipelineunit.

sic-bre avatar sic-bre commented on June 9, 2024

I don't understand your comment "I'd prefer doing it on junit though."? My proposed changes setup the local test environment so that the tests which are still in junit are left unchanged. I don't see how you can do this inside the junit tests themselves as the information about repositories and networking has to be passed to it somehow. Making the tests work behind a firewall you can't assume anything except that the user has set up for Gradle itself for the local network. In our case we use a standard init.gradle script to run a plugin in settings.gradle which among other things remaps all the repositories and configures pluginManagment settings. Other people may choose to set the global java proxy settings but that can't be assumed to work everywhere.

from jenkinspipelineunit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.