Bug: arguments are doubled about docker-agent HOT 15 CLOSED

Having the same issue, spawning slave pods up until it hits container cap.

from docker-agent.

So it has been caused by jenkinsci/docker-inbound-agent#24 from @carlossg. Who is also a maintainer of Kubernetes. The most straightforward way would be to skip parameters if the Env Vars are specified, but it needs ack from @carlossg . I am not sure which use-cases he had in mind

from docker-agent.

I didn't expect people would pass both args and env vars, so I guess it needs to check for that and use only args in that case

from docker-agent.

@carlossg Yes, this is also my hotfix plan. Will you be able to implement it and test with your Kubernetes stuff?

from docker-agent.

@carlossg

I didn't expect people would pass both args and env vars, so I guess it needs to check for that and use only args in that case

It happens even when I define no env vars.

from docker-agent.

It's hard to say what is the"root cause". a) the kubernetes plugin which adds args AND env variables or b) the jnlp-slave!?
Currently, when using the kubernetes plugin, I have to explicitly add "containerTemplate(name: 'jnlp', image: 'jenkinsci/jnlp-slave:2.62-alpine', args: '${computer.jnlpmac} ${computer.name}')" to my podTemplate.

The OLD jenkinsci/jnlp-slave:2.62-alpine ist still working.

Does anybody has a better workaround?

from docker-agent.

Seems @carlossg is not available to fix that. Doing it on my own.

from docker-agent.

@TGippert we started having this issue after the docker image got updated I believe. We solved it the same way you described: just freezing docker image version. Not sure there is a better workaround.

from docker-agent.

Created the pull request: jenkinsci/docker-inbound-agent#33

from docker-agent.

Both latest and alpine images have been updated, please confirm the fix works for you

from docker-agent.

Great job! Thanks 👍

containerTemplate(name: 'jnlp', image: 'jenkinsci/jnlp-slave:alpine', args: '${computer.jnlpmac} ${computer.name}', alwaysPullImage: true)
writes the following into the output of the jnlp agent:
Warning: SECRET is defined twice in command-line arguments and the environment variable
Warning: AGENT_NAME is defined twice in command-line arguments and the environment variable

So I decided to use the containerTemplate without args
containerTemplate(name: 'jnlp', image: 'jenkinsci/jnlp-slave:alpine', alwaysPullImage: true)

from docker-agent.

@TGippert warnings are "as designed" from this repo PoV, because it is generally not an expected configuration.

@carlossg will still need to triangulate and fix the issue on the Kubernetes plugin side. Likely it is a containerTemplate() documentation update

from docker-agent.

@oleg-nenashev confirmed working.

I had to add jnlp containerTemplate to my podTemplate with alwaysPullImage: true since my k8s cluster has cached old alpine image.

from docker-agent.

@thefron Will add more tags as a part of #729

from docker-agent.

Since Google pointed me here and others might come as well, the jenkinsci/jnlp-slave has been deprecated now. You need to use jenkins/jnlp-slave:<tag>, where tag can be either: alpine (88MB) or latest (296MB). https://hub.docker.com/r/jenkins/jnlp-slave/tags/

from docker-agent.