GitHub repos named `.github` and `.github-private` are not supported about jx HOT 3 OPEN

Somewhat related PR - jenkins-x-plugins/jx-gitops#287

from jx.

In regards to this error example:

error: failed to validate: failed to find build number: failed to find BuildNumber: failed to lazily create 
PipelineActivity myorg-github-private-pr-1-1: PipelineActivity.jenkins.io "myorg-github-private-pr-1-1"
is invalid: metadata.labels: Invalid value: ".github-private": a valid label must be an empty string or 
consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character 
(e.g. 'MyValue',  or 'my_value',  or '12345', regex used for validation is 
'(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])?')

The source of the issue appears to stem from the normalizing of names and/or labels in the PipelineRun which results in an error downstream when the logic tries to generate a PipelineActivities and can not find any PipelineRuns with a matching repo name.

When digging down the logic, it seems like much of the code paths end up using the ToValidValue helper method in the naming module of jenkins-x/jx-helpers, which ends up stripping characters like ..

.e.g. the name or label generated for repo: github.com/myorg/.github-private.git ends up being myorg-github-private

What I experienced locally, is that JX3 correctly triggers a PipelineRun for the .github-private repo, which functions as expected. However, no PipelineActivity k8 object is never generated as that logic fails to find a PipelineRun for .github-private as all the PipelineRun labels have been sanitized too: github-private.

At least that is what appears to be occurring...

from jx.

The workaround we are currently using is simply to use GitHub Actions for linting the .github and .github-private repos. The repos are still imported into JX3; however, I've removed the .lighthouse folder so that we can still utilize JX3 for ChatOps.

from jx.