Giter Club home page Giter Club logo

Comments (10)

halkeye avatar halkeye commented on September 23, 2024 1

We also can make the plugin site API check the etag and pull it if changes. There's lots of ways to handle it. I can update update center to split them.

My vote is keep the UI on plugin site.

from plugin-site.

zbynek avatar zbynek commented on September 23, 2024

Do you want to keep the current URL or could those be moved? (https://updates.jenkins.io/download/plugins/log-cli/ to the plugin site, https://updates.jenkins.io/download/war/ seems to be a duplicate of https://get.jenkins.io/war/ so maybe those could be merged). If moving is OK, the update center could just dump the information in JSON and the plugin site would process it (as a React component).

from plugin-site.

daniel-beck avatar daniel-beck commented on September 23, 2024

Would keep the current URLs; it's important that it's effective immediately, otherwise that would negate recent improvements.

from plugin-site.

zbynek avatar zbynek commented on September 23, 2024

Initial commit in jenkins-infra/update-center2#469

from plugin-site.

halkeye avatar halkeye commented on September 23, 2024

do we have all the data in plugin site? or can get it? I feel like it would make a great new tab like npm does.

from plugin-site.

daniel-beck avatar daniel-beck commented on September 23, 2024

There's plugin-versions.json but it's very expensive to download (10+ MB IIRC), which is why it's not documented on the root page of https://updates.jenkins.io/

And, again, a big benefit of the current design is that new releases are visible immediately there. It's an easy way to start troubleshooting distribution.

from plugin-site.

zbynek avatar zbynek commented on September 23, 2024

Well if the update center would export these as per-plugin JSON, the plugin site could fetch them from client side and render them nicely, there would also be no delay. That would remove the need to maintain frontend code (CSS, template substitution) in an otherwise backend repository, on the other hand the static HTMLs from the PR above could be used also pushed to the mirrors to make them look a bit nicer... not sure what's the best way forward 🤷

from plugin-site.

daniel-beck avatar daniel-beck commented on September 23, 2024

maintain frontend code (CSS, template substitution) in an otherwise backend repository

If the plugin site didn't show me different information practically every time I reload the page, perhaps. I just don't trust it to act as a stable resource to determine which releases exist or which is the newest one, especially when I (in my admittedly unusual use case) need to be certain what's shown matches the current update center content exactly.

Given my use case, and given the update center is intended as a standalone component, I will move forward with my proposed solution. At a minimum, it should get all the low-tier "security researchers" off my back who keep reporting visible directory indexes as security vulnerabilities. If you want to replace the archives link on the plugins site with something different, feel free.

could be used also pushed to the mirrors

If they're configured to render index.html as directory indexes, which they might not be. Additionally, has a problem when the index page is nontrivial, e.g. for the https://updates.jenkins.io/ index I was unable to use admonitions due to (IIRC) CORS.

from plugin-site.

zbynek avatar zbynek commented on September 23, 2024

Well, we can have both. Finish jenkins-infra/update-center2#469 now (mostly for distribution debugging purposes) and enhance the "Releases" tab in the future to also include download links (for Jenkins administrators).

from plugin-site.

halkeye avatar halkeye commented on September 23, 2024

I'm going to close this as the new releases tab is powered by update center instead of github, it'll have all the download links baked in.

from plugin-site.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.