Giter Club home page Giter Club logo

Comments (16)

krisstern avatar krisstern commented on August 20, 2024

Hi @sridamul! You should probably open an issue at https://github.com/jenkins-infra/jenkins-io-components and reference this. Our navbar component is currently located there.

from jenkins.io.

krisstern avatar krisstern commented on August 20, 2024

This is actually a known issue

from jenkins.io.

sridamul avatar sridamul commented on August 20, 2024

Hi @krisstern,

Thanks for the clarification. I'll go ahead and close the issue now. Do you recommend opening a new issue at https://github.com/jenkins-infra/jenkins-io-components?

from jenkins.io.

krisstern avatar krisstern commented on August 20, 2024

Please do not close this issue but reference back to this for better tracking.

from jenkins.io.

krisstern avatar krisstern commented on August 20, 2024

Hi @krisstern,

Thanks for the clarification. I'll go ahead and close the issue now. Do you recommend opening a new issue at https://github.com/jenkins-infra/jenkins-io-components?

Yes, I have already said so

from jenkins.io.

sridamul avatar sridamul commented on August 20, 2024

Okay! Grateful for your clarification.

from jenkins.io.

Rekha-Ahir avatar Rekha-Ahir commented on August 20, 2024

Screenshot 2023-12-09 025452
@krisstern and @sridamul
We can do it by giving margin right property 11rem to .navbar nav in success stories page

from jenkins.io.

krisstern avatar krisstern commented on August 20, 2024

@Rekha-Ahir Could you please see if you could open a pull request to address this issue? I have a feeling this is not possible in the https://github.com/jenkins-infra/jenkins-io-components because multiple sites are already using the same navbar from this component except maybe the plugin site. And, I am not actually sure if we are planning to change the plugin site navbar at all.

from jenkins.io.

Rekha-Ahir avatar Rekha-Ahir commented on August 20, 2024

@krisstern i think you are right it will effect all the component but i will try to look out the issue by pull request

from jenkins.io.

sridamul avatar sridamul commented on August 20, 2024

@krisstern, just to clarify, the only difference is in the contribute spotlight nav bar. The plugin site and success stories maintain the same style (without a search bar), while the remaining tabs have consistent nav bar layouts (with a search bar). Therefore, I suggest focusing our attention solely on the contributor spotlight. What are your thoughts on this?

from jenkins.io.

krisstern avatar krisstern commented on August 20, 2024

Hi @sridamul I am not sure I am getting what you are saying 100%, we are just using the navbar component from @jenkinsci/jenkins-io-components as is currently:
https://github.com/jenkins-infra/contributor-spotlight/blob/main/gatsby-ssr.jsx#L10.

from jenkins.io.

krisstern avatar krisstern commented on August 20, 2024

There is however some additional styling added for the plugin site navbar in https://github.com/jenkins-infra/plugin-site/blob/d87b02f35a0cc859a0e3a5619d6d0039e13e09d1/plugins/plugin-site/src/styles/base.css.

from jenkins.io.

sridamul avatar sridamul commented on August 20, 2024

Is there a same styling for the success stories too?

from jenkins.io.

krisstern avatar krisstern commented on August 20, 2024

If it is just a font size change needed for the navbar in contributor-spotlight I can take care of that.

from jenkins.io.

sridamul avatar sridamul commented on August 20, 2024

Yep, I think so

from jenkins.io.

krisstern avatar krisstern commented on August 20, 2024

Just submitted a PR to fix this, by setting a default fontsize in contributor-spotlight.

from jenkins.io.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.