Giter Club home page Giter Club logo

Comments (3)

jenkins-infra-bot avatar jenkins-infra-bot commented on September 24, 2024

orrc:

I fixed the infobox for this particular plugin by adding the sourceDir parameter to the macro.

The SCM URL is indeed built by very simple string concatenation.

The main decision the infobox makes is whether the plugin is hosted on "github.com", by looking at the scm value for the plugin:
https://github.com/jenkinsci/backend-jenkins-plugin-info-plugin/blob/8f210f0/src/main/java/org/jenkinsci/confluence/plugins/JenkinsPluginInfoMacro.java#L128

However, the scm value comes directly from the Update Centre JSON, which unfortunately only contains the SCM hostname:
https://github.com/jenkinsci/backend-update-center2/blob/c01fe35/src/main/java/org/jvnet/hudson/update_center/Plugin.java#L341-L344

So it would be necessary to add a further field with the full SCM URL to the Update Centre JSON, and then use that (if present) in the infobox plugin.

from helpdesk.

jenkins-infra-bot avatar jenkins-infra-bot commented on September 24, 2024

rtyler:

Daniel Beck since you've been tinkering around in the plugin-info plugin, would you be interested in picking this up?

from helpdesk.

jenkins-infra-bot avatar jenkins-infra-bot commented on September 24, 2024

danielbeck:

I don't think anything needs to be done here about the macro. Git repositories are tiny compared to other SCMs, typically only providing one or a handful of closely related projects, so sourceDir for repo-level granularity should be good enough.

from helpdesk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.