HTTP/500 error `Could not resolve placeholder 'url'` when creating an account about account-app HOT 5 CLOSED

Just remove the lib we don’t need it I was planning on doing it soon anyway, locally I’ve been testing with it commented out which explains why I missed this

from account-app.

At first glance,

Which leads to https://github.com/jenkins-infra/jira-ldap-syncer/blob/6c34e8d23b6da2b19be3c43346be5b98c5f926ce/src/main/java/io/jenkins/backend/jiraldapsyncer/ServiceLocator.java#L37

from account-app.

=> https://github.com/jenkins-infra/jira-ldap-syncer/blob/6c34e8d23b6da2b19be3c43346be5b98c5f926ce/src/main/resources/serverAppContext.xml#L47 expects the url placeholder which is not there anymore. I assume the changes we did in the past weeks/month on the application created this misconfiguration.

from account-app.

@timja @NotMyFault could I have your eye to confirm my understanding:

• In the PR #175 we introduced the new configuration library in order to makes the application configuration more modern
• As part of the PR, the entrypoint of the account-app image was updated with the flag -Durl=${LDAP_URL} removed (4d213fc#diff-6f9d41d046756f0ddc2fcee0626bdb50100d12b88f293734eff742818e03efa2L44).
• But it seems that the dependency "ldap-syncer" was not updated to benefit from the new config library. Any call to code of this dependency are now failing because the placeholder url is now empty.

=> I understand that users are created in the LDAP, but not synchronized to JIRA due to this.

Could you help me on solving this? My java-fu is bad so I was going to open a PR to reintroduce the parameter in the entrypoint. but there might be "cleaner" ways to do it?

from account-app.

Project https://github.com/jenkins-infra/jira-ldap-syncer archived (with a readme message pointing here)

from account-app.