Giter Club home page Giter Club logo

Comments (4)

sevenrats avatar sevenrats commented on July 19, 2024 1

if you have time to play with this i would look at the text overflow parameters. iirc flutter offers "ellipsis" and "fade" and both can be used with or without line wrap. frankly we depend on non-english readers to tell us which combination of these is going to look better more often.

edit:
it occurs to me that the text scales now in develop too so maybe a soluton could involve exposing a config view with a slider for the text size. I kinda always meant to write that into the text scaler anyway because it could allow the text to be scaled way way up for accessibility purposes.

from jellyflix.

jdk-21 avatar jdk-21 commented on July 19, 2024

This kind a of a different problem. Normally we do have a way to extend the text in one direction or it isn't important to fully see the text. In this case you should be able to see the whole label even if you have to scale it down. Or we scale up the width of the navbar.
I assign you the issue, let me know if you need something.

from jellyflix.

sevenrats avatar sevenrats commented on July 19, 2024

I've given this some thought and I think we implement the solution in the form of contributor and/or style guidelines. We should simply divine what our maximum string length reasonably is and force the user to use it. It's a bit outside my wheelhouse but it would be neat if we could make the CI enforce it. Then, if we encounter a situation where a contributor just can't make a particular string work, then and only then do we do the hard work of re-evaluating the layout code.

from jellyflix.

sevenrats avatar sevenrats commented on July 19, 2024

ok this has progressed in chat just a bit and I think we have established that the standard solution is just implementing TextOverflow.Ellipsis
No reason we need to make it more complicated than that.

from jellyflix.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.