Giter Club home page Giter Club logo

Comments (12)

iwalton3 avatar iwalton3 commented on May 18, 2024 1

I'd say if someone in the community wants to do this that's fine, but the 2.5 hour build process thing is kind of a deal-breaker. I am of course willing to change my mind on this if a ton of people request it though.

from jellyfin-media-player.

iwalton3 avatar iwalton3 commented on May 18, 2024

This depends entirely on if outside contributors are able to get it working. Note that the build system uses Catalina, so this may pose issues to shipping for older versions.

from jellyfin-media-player.

yuxincs avatar yuxincs commented on May 18, 2024

If we want support of Mojave or earlier, we need to set the macOS deployment target to be lower. It not only needs to be set for jellyfin media player itself but also all its dependencies (mpv / FFmpeg and their dependencies as well).

However, homebrew is configured to target the macOS version it is built on and GitHub Actions doesn't provide older macOS. This means we need to build everything from source and set the deployment target to be 10.14. So with the help of mpv-nightly-build I hacked the homebrew formulae and build a version that targets 10.13, and runs well in a vm. But it takes ~2.5hrs to finish. We could possibly strip out some unnecessary dependencies (maybe some encoders for ffmpeg), but the total time would still be substantially longer than before. Caching may help but I read somewhere that GitHub Actions only keep cache for a week or so.

@iwalton3 not sure what you think, maybe we could have two build configs where mpv is only built on release branch and on test branch we just simply run brew install mpv.

Just a side note if we want to support Mojave: for macOS 10.14.3 and earlier, we need to bundle swift libraries otherwise the user has to install swift runtime.

from jellyfin-media-player.

ripley1901 avatar ripley1901 commented on May 18, 2024

Jellyfin has clients for all kinds of tv os, but still no easy-to-use clients for mac except for kodi plugin and its performance is not ideal on mac.
I believe there's lots of Mac users like me who still stuck in older mac os, either for old hardware or lack of attracting new feature worth the upgrade.

from jellyfin-media-player.

iwalton3 avatar iwalton3 commented on May 18, 2024

Yeah it's just unfortunate that all the build infrastructure and packaging has moved on. So you have to do things like multi-hour CI builds.

from jellyfin-media-player.

iwalton3 avatar iwalton3 commented on May 18, 2024

If someone can make a GitHub Actions job that builds in under 40 minutes I'd gladly use it.

from jellyfin-media-player.

jameskimmel avatar jameskimmel commented on May 18, 2024

Jellyfin has clients for all kinds of tv os, but still no easy-to-use clients for mac except for kodi plugin and its performance is not ideal on mac.

I use Chrome for my old Mac and it works pretty good (Transcode 5.1 to Stereo). Maybe give that a try?

from jellyfin-media-player.

Ribero avatar Ribero commented on May 18, 2024

Probably not worth the effort of having a pre Catalina version of the client in regards to the number of potential users. And I support the fact that ressources should concentrate on new features.
That makes sens.

from jellyfin-media-player.

findyy99 avatar findyy99 commented on May 18, 2024

So, may I ask that is there any release for 10.14 now?

from jellyfin-media-player.

yuxincs avatar yuxincs commented on May 18, 2024

So, may I ask that is there any release for 10.14 now?

@findyy99 I don't think there is, as we have discussed above. But it's fairly simple to build on your own (https://github.com/jellyfin/jellyfin-media-player#building-for-macos)

from jellyfin-media-player.

MrAlucardDante avatar MrAlucardDante commented on May 18, 2024

1.8 is no longer compatible with Catalina and requires at least Big Sur. We can still downgrade to 1.7, but that’s really unfortunate

from jellyfin-media-player.

sevenrats avatar sevenrats commented on May 18, 2024

Mojave has been EoL for two years. You will have to follow the instructions to build yourself on unsupported operating systems.
Stop by the chat spaces and I will help you build it.

from jellyfin-media-player.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.