Giter Club home page Giter Club logo

Comments (7)

jeffreytse avatar jeffreytse commented on May 18, 2024 1

Hi @peimanja

Thanks for the suggestion, I will take a consideration and work on this as soon as possible. And welcome to star this project for further update in the future.

Thanks & Regards

from jekyll-deploy-action.

peimanja avatar peimanja commented on May 18, 2024 1

Hi @peimanja

I have a question on the requirement, why you don't want to create a branch for test purpose?

Thanks & Regards

Thanks for he quick response. On pull requests we deploy a preview version on netlify using https://github.com/nwtgck/actions-netlify action and after merging the PR we deploy it on Github pages

right now we use https://github.com/helaili/jekyll-action action but we are looking for a better maintained action and yours looks very good.

so adding an option like this:

build_only: ${{ github.event_name == 'pull_request' }}

would only build but won't publish it to github pages branch

from jekyll-deploy-action.

itrich avatar itrich commented on May 18, 2024 1

Same here! We're looking for a way to build the site on every branch but only pushing if the source branch is 'main'. This would allow us to test pull requests before merging.

from jekyll-deploy-action.

ZibingZhang avatar ZibingZhang commented on May 18, 2024 1

Just wanted to add that another use case (the one I'm looking for) would be when I have multiple sub directories that need building before deploying all together, e.g. a jekyll subdir and a react-project subdir. In the meantime I've taken to cloning this repo locally and removing the publishing functionality. Thanks for the amazing action!

It would also be nice if we could customize the name of the build folder.

from jekyll-deploy-action.

jeffreytse avatar jeffreytse commented on May 18, 2024 1

Hi @peimanja @itrich,

Thanks for your issue and patience for the feature, now I have added this feature in the latest version. Welcome to update for better convenience.

Thanks & Regards

from jekyll-deploy-action.

jeffreytse avatar jeffreytse commented on May 18, 2024

Hi @peimanja

I have a question on the requirement, why you don't want to create a branch for test purpose?

Thanks & Regards

from jekyll-deploy-action.

jeffreytse avatar jeffreytse commented on May 18, 2024

Hi @peimanja, @itrich,

I agree with you, currently I am busy, I will work on this as soon as possible. : )

Thanks & Regards

from jekyll-deploy-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.