Re-setting options on an existing instance can have side effects about react-codemirror HOT 8 CLOSED

@justindeguzman I ended up forking this project pretty aggressively since it seemed dormant for awhile. To solve this particular problem I added some functions to test "deep" object/array equality.

function deepEquals(thing1, thing2) {
  if (thing1 === thing2) {
    return true;
  } else if (Number.isNaN(thing1) && Number.isNaN(thing2)) {
    return true;
  } else if (Array.isArray(thing1) && Array.isArray(thing2)) {
    return arraysEqual(thing1, thing2);
  } else if (typeof(thing1) === 'object' && typeof(thing2) === 'object') {
    return objectsEqual(thing1, thing2);
  } else {
    return false;
  }
}

function arraysEqual(array1, array2) {
  if (array1.length !== array2.length) {
    return false;
  } else {
    return array1.every(function(item, index) {
      return deepEquals(array1[index], array2[index]);
    });
  }
}

function objectsEqual(obj1, obj2) {
  if (obj1.constructor !== obj2.constructor) {
    return false;
  }
  var obj1Keys = Object.keys(obj1);
  var obj2Keys = Object.keys(obj2);
  if (!arraysEqual(obj1Keys.sort(), obj2Keys.sort())) {
    return false;
  }
  return obj1Keys.every(function(key) {
    return deepEquals(obj1[key], obj2[key]);
  });
}

  setCodeMirrorOptionIfChanged: function(optionName, newValue) {
    var oldValue = this.codeMirror.getOption(optionName);
    if (!deepEquals(oldValue, newValue)) {
      this.codeMirror.setOption(optionName, newValue);
    }
  },

from react-codemirror.

Okay, thinking about this more; using JSON.stringify would almost certainly cause other bugs, since there are a handful of CodeMirror options that take functions as values.

from react-codemirror.

@attaboy Were you able to find a solution?

from react-codemirror.

Have a fork published anywhere? Really like to get linting to work...

from react-codemirror.

@cacois I just created a pull request that I believe fixes the problem with lint: #93

from react-codemirror.

@attaboy Thanks for the note!

Plugged your branch in to give it a test, but I don't see any change in behavior in my app. Any specific guidance on getting it working? I'm basically just importing libraries adding the lint: true, gutters: ['CodeMirror-lint-markers'] options.

from react-codemirror.

@cacois Which lint plugin are you trying to use? I'm using jshint successfully in my project by requiring addon/lint/lint and add-on/lint/javascript-lint and ensuring that the JSHint library is loaded already (globally, which is an assumption that the javascript-lint add-on makes).

from react-codemirror.

@attaboy Got it! Turns out I wasn't getting the JSHINT function to be globally available, as necessary. Once I figured out how to import it properly, things began working fine. Thanks!

from react-codemirror.