SSH command wrapped in quotes breaks on Windows about rsyncwrapper HOT 9 CLOSED

Hi! Thanks for your input, sorry it took me awhile to respond - been having some internet connectivity issues.

So it sounds like Windows is choking on the way I'm building that part of the command string with the escaped double quotes and whatnot.

Sorry, I don't have any knowledge about how quotes and escaped quotes work in a Windows shell. I think single quotes will work too with the -e option. What if you change line 62 to,

args.push("-e 'ssh -p " + options.port + "'");

does it work then?

from rsyncwrapper.

Hmm nope, no dice. If I change it to:

args.push("-e ssh -p " + options.port);

Then it works. I noticed this file/line was updated in ceda6ee .

from rsyncwrapper.

Just to add, I've gotten a co-worker on a Mac to test, and he gets the exact same error if line 62 remains as it is (inside quotes). If he removes the quoting to:

args.push("-e ssh -p " + options.port);

then it works on his machine too. I can create a PR with this fix, but I am unaware of why ceda6ee was added in the first place, so I wouldn't want to conflict with that commit's reasoning.

from rsyncwrapper.

Hum. That's odd. We're putting the -e option in to specify a non-default SSH port. From the rsync manpages (http://linux.die.net/man/1/rsync) and most of what I can Google it looks like the syntax for the -e option is to wrap the value in quotes. Although I confess that that commit came in from a 3rd party too who said he'd tested it, but maybe he hasn't.

Can you confirm that it works without the quotes and still picks up the non-default port number? i.e. have you got an SSH server running on some port other than 22 that you can test against?

I'll do some testing my end too ...

from rsyncwrapper.

Or it could be we're just not escaping the quotes properly ...

from rsyncwrapper.

I don't have a server running on a port other than 22, but I just tested the inverse.

I specified port 4444 on a server that actually runs on port 22, and the connection was refused, so it seems to be accepting the port parameter just fine while unquoted.

from rsyncwrapper.

I can confirm that the suggestion by rabhw works for me on Windows, I run ssh on a non standard port.

from rsyncwrapper.

I can confirm that removing the quotes works for me on Mac for using rsunc on non standard port.

from rsyncwrapper.

OK, the way we're building the rsh option and its sub command has been re-worked a bit in the latest version 0.0.17. Let me know if this sorts your issues for you.

729ddab

from rsyncwrapper.