maxBuffer exceeded. about rsyncwrapper HOT 3 CLOSED

Hey. Yeah, I think exec buffers stdout and stderr before returning it to Node all in one go, whereas spawn will launch a new process and stream the output back to Node. The max buffer for exec is only 200*1024 bytes. In your rsyncwrapper options are you specifying any options that could cause it to return a lot of information back to Node in stdout (--progress or --stats for example)? That could be pushing you over the buffer limit ... ?

In any case it sounds like it might be a good idea to swap this over to spawn anyway. Feel free to fork and pull request, or else I'll add this to my to-do list! ^^

from rsyncwrapper.

Perhaps it was using the --dryRun option. Either way I was able to fix it by using spawn. The major difference is the complete callback, where spawn does not return a single callback, but instead allows you to listen on the data stream. By listening on exit you can safely determine the process completed with or without errors but it may be an architecture change for this package. Do you have any thoughts?

This is what I have which obviously ignores errors:

var process = spawn('rsync', args);

process.stdout.on('data', function (data) {
  console.log('stdout: ' + data);
});

process.stderr.on('data', function (data) {
  console.log('stderr: ' + data);
});

process.on('exit', function (code) {
  console.log('child process exited with code ' + code);
  callback(null,null,null,null);
});

from rsyncwrapper.

Great, thanks for the code! Fixed in 543b3a5.

from rsyncwrapper.