Footer misalignment when any text.Color is used in the Transformer about go-pretty HOT 6 CLOSED

Thank you for getting back to me so quickly @jedib0t . I tried the workaround you suggested and it worked perfectly. Thanks a lot mate.

Btw, what I said was not just a complement! That's a beautiful piece of work buddy. Good on ya!

from go-pretty.

Yeah I have a fix in the pipeline for this. Give me a day or two. See if you can use the commit hash instead of the version tag.

from go-pretty.

Hey thanks for the compliments. My first open-source project, so I'm a little attached to it at the moment. 😄

Found the bug b.t.w, your custom transformer is returning Bold text which looks like this with escape sequences: �[1m10000�[0m. The code then applies the style's formatter for the footer which is text.FormatUpper which converts the case-sensitive escape sequences too: �[1M10000�[0M. And this is basically garbage to the terminal emulator. I'm guessing the same bug should be show up in headers too if you use TransformerHeader.

I'll fix it this week. 👍

But if you can't wait for a fix until then, you can use this workaround before calling t.Render():

    t.Style().Format.Footer = text.FormatDefault

from go-pretty.

@xitonix Thanks for reporting the bug btw. I appreciate it!

from go-pretty.

Hey @xitonix the latest code in master branch has the fix (d24d83b, 8b58fba). I'll cut a tag by end of week.

Out of curiosity, do you use go mod or dep for dependency management? I transitioned to go mod some time back, but I figured recently that I've not done major versioning the way go mod likes it. I can fix that, but that may break dep support.

from go-pretty.

Hey mate. I do use go mod, but because of the reason you mentioned yourself above, it cannot pick up the right version unfortunately. But I don't really understand why go mod always fetches v4.3.0 while you don't even have a v4 branch, even though I explicitly asked for v5.0.1! This is what appears in my go.mod file after I run:

go get github.com/jedib0t/[email protected]

github.com/jedib0t/go-pretty v4.3.0+incompatible

from go-pretty.