Giter Club home page Giter Club logo

Comments (4)

jebrosen avatar jebrosen commented on June 16, 2024

This is explained by the Rocket guide, but it's not easily "guessable" that TokenRequest uses Cookies. The current message Warning: The OAuth2 state returned from the server did not match the stored state. is misleading. I will definitely change that to something like Error: Unable to access request cookies. Is a Cookies guard already active?

probably nothing that documentation can't manage.

Do you have any suggestions on where to put this documentation? As in, the API docs for TokenResponse, the top-level documentation/examples, or in the examples/ directory?

from rocket_oauth2.

sd2k avatar sd2k commented on June 16, 2024

I can see it fitting in all of those places, but the top-level docs/examples and API docs for TokenResponse would be most visible I think.

from rocket_oauth2.

jebrosen avatar jebrosen commented on June 16, 2024

Alright, I made the following two changes:

  • e0ed071 changes the log message for "cookie missing" vs "cookie mismatch". Unfortunately there's not a good way to distinguish "Cookies guard in the wrong order" from "the cookie is missing", so the error message is a "best effort".
  • 7b825fe adds some explanation to the docs and doc examples.

I think this addresses your concerns.

from rocket_oauth2.

sd2k avatar sd2k commented on June 16, 2024

That looks fantastic, thanks!

from rocket_oauth2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.