Giter Club home page Giter Club logo

Comments (8)

jdbranham avatar jdbranham commented on May 31, 2024 2

This works now, but I'm not sure which version fixed it - so unable to link here.

from grafana-diagram.

njmike avatar njmike commented on May 31, 2024 1

I'm experiencing the same behavior - clicking on a link that should be embedded by valid Mermaid syntax does not respond.

I've got Diagram 1.4.0 installed on Grafana v4.5.2

Using example from: https://mermaidjs.github.io/flowchart.html
graph LR;
A-->B;
click A callback "Tooltip for a callback"
click B "http://www.github.com" "This is a tooltip for a link"

Works in the live editor: https://mermaidjs.github.io/mermaid-live-editor/

But not in the diagram plugin.

Thank you in advance, for your time.

from grafana-diagram.

briangann avatar briangann commented on May 31, 2024

Tried this out, looks like the method name above is incorrect, it should be bindFunctions:

After line 210 in diagramControl.js, add:

bindFunctions(diagramContainer[0]);

I can submit a PR if you like.

from grafana-diagram.

andrewthad avatar andrewthad commented on May 31, 2024

@briangann is right. It's supposed to be bindFunctions.

from grafana-diagram.

FareehaNaaz avatar FareehaNaaz commented on May 31, 2024

Hi! i was facing the same issue, and tried adding bindFunctions(diagramContainer[0]); / bindEvents(diagramContainer[0]); in the file diagramControl.js line 210, and 1) restarted grafana and 2) rebuilt package but neither of this helped.

from grafana-diagram.

rdegez avatar rdegez commented on May 31, 2024

Hi, i'm facing the same issue, adding bindFunctions(diagramContainer[0]) didn't help.
In the grafana dashbord, the diagram is still not clickable when using diagram definiton like:
click XXX "http://xxxx" "link tooltip"

Am I missing something ?

from grafana-diagram.

jag3773 avatar jag3773 commented on May 31, 2024

Any possibility of getting this fixed in an updated release?

from grafana-diagram.

jag3773 avatar jag3773 commented on May 31, 2024

Excellent! I can verify this works in Grafana v6.2.5 (commit: 6082d19) and grafana-diagram 1.4.4.

from grafana-diagram.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.