Problem with 'accounts-facebook' package about crater HOT 7 CLOSED

@unski11ed okay, this should be fixed now. Make sure to rerun npm install after merging changes from this repo. Let me know if you have any issues and I'll reopen this. Thanks!

from crater.

Sorry for the delay, I did just manage to repro. I'm looking into it now...I'm wondering if those packages are missing for some reason?

from crater.

@unski11ed okay, it's because meteor-imports-webpack-plugin excludes reload. I'll have to patch it.

from crater.

@unski11ed okay, if you install the latest version of meteor-imports-webpack-plugin it should fix these errors.

from crater.

@unski11ed actually I was wrong, I think getting oauth to work won't be too bad, but I have to fix a few more things. I'll let you know once it's done

from crater.

God, thanks a lot Mate. My heart stopped when i saw your message about the potential big problems with oauth. Great it turned out to be not so scary ;)

from crater.

@unski11ed you're welcome, yeah I'm glad too. I thought oauth relied on injecting some elements into the HTML of any page served up, but I was wrong, it just has to render a template for the oauth routes shown in the popup, not so bad.

And thanks for reporting this, I found a lot of things to improve thanks to this, including making meteor-imports-webpack-plugin import .css files from Meteor packages, serve static assets from Meteor packages, and not import static .js assets.

from crater.