Giter Club home page Giter Club logo

Comments (6)

jbyuki avatar jbyuki commented on May 31, 2024

Thank for your useful feedback. I'll make sure to correct the wrong behaviour you mention.

  1. Indeed, I very rarely use the undo for some reason in vim. Thus I wasn't aware that it saved modifications every time your exit insert mode. I pushed a commit which should modify the behaviour. Hopefully it works.
    I didn't encounter bugs for line delete, maybe could you provide a reproducible example? Then I could see what's wrong.

  2. I'm not sure but I think this bug is only present if you're using Neovim v0.4. With 0.5, it should put the correct filetype automatically. I might be wrong and should probably look more into it.

from instant.nvim.

seblj avatar seblj commented on May 31, 2024

I uploaded a small video recording of my problems. This is from just a couple of minutes ago, and I updated to the new commit that you just pushed. It seems like I can't undo at all now after the most recent commit.

Screen.Recording.2021-03-05.at.20.30.08-2.mov

from instant.nvim.

jbyuki avatar jbyuki commented on May 31, 2024

The video was very helpful to debug the issue. I further narrowed down the issue to an error when the first line is restored. Hopefully the last commit will fix the issue. I probably suspect it was also the issue that you mentionned with deleting a line on a previous post.

from instant.nvim.

seblj avatar seblj commented on May 31, 2024

Just tested the new commit, and the undo seems to be fixed when it comes to deleting lines. However it still seems to not behave correctly when I try to undo a line I just typed in. If I opened the same file as on the video and tries to type in the same as on the video, something strange is happening when I try to undo this. It manage to delete some characters, but then add some others. Then it suddenly shifts up a line, just as if I pressed J for join. I tried to undo a printf("testing"); under the print of hello world, and when I received the message "Already at oldest change" it looked like this:
printf("Hello World!");rippprprinritntrfint")

from instant.nvim.

jbyuki avatar jbyuki commented on May 31, 2024

Hopefully this will fix the issue. I tested on my machine before committing and didn't find any wrong behaviour. I also added an automatic filetype detect which will trigger when a client receives buffer content from the buffer. This should fix the filetype issue.

from instant.nvim.

seblj avatar seblj commented on May 31, 2024

Thank you! In my small testing right now it seems to have fixed both issues. Closing this now!

from instant.nvim.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.