Giter Club home page Giter Club logo

Comments (4)

jbreams avatar jbreams commented on August 29, 2024

Do you have a stacktrace or a core dump or something I could look at? I just tried creating a test password item with a one-time password and it didn't crash for me.

from gonepass.

jbreams avatar jbreams commented on August 29, 2024

Well, the coredump wasn't usable because I don't have a copy of your binaries. Also, I realized coredumps are probably a bad idea here. I had a theory that maybe OTP fields have binary data that isn't null-terminated, but it looks like binary data gets base64 encoded, and the JSON library I'm using guarantees all strings will be null-terminated after version 2.6. Do you think you could construct a test keychain with fake passwords that causes the problem?

from gonepass.

joaosoares avatar joaosoares commented on August 29, 2024

This problems happens because there's no error checking when unpacking the json string for a section without a title (like OTP sections). I have fixed it by checking the error code that json_unpack throws on the process_section function. I'm finishing including support for OTPs and then I'll most likely submit a pull request, if that's fine.

from gonepass.

jbreams avatar jbreams commented on August 29, 2024

Great thanks!

from gonepass.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.