build clarifications about synology-gitlab-ce HOT 9 CLOSED

I've taken your approach and improved it a bit. The version is now optional and when you not provide it you will get automatically a list of 9 latest versions to select from. I think this is more intuitive than a simple listing command and hope you like it.

I've done some cherry-picking on your PR and modified it. You will find the final result in the master

Clarification: done
Unify Arguments: done

Thank you four your contribution.

from synology-gitlab-ce.

You can build on any linux, you just need jq installed. :-)
I will clarify it in the readme :-)

from synology-gitlab-ce.

great!

Next question:
Is there a reason the version on the build script is not treated the same as the other 2 parameters? I would change it to --version so it is consistent.

from synology-gitlab-ce.

as is now, it is actually rater odd:
if you build without parameter, it suggest to use the latest version by default. how ever if you appen one of the options, the version must explicitly be noted (although one might not now which ones are available).
I therefore would be nice to show all available version.

=> I will try to see if I find a way for this

from synology-gitlab-ce.

i have a way, for that already in code, but i take only the latest.

from synology-gitlab-ce.

I have already a list solution, i can list the lastest 8 - 10 (for more there is paging required and its unnessesary) versions and make them selectable if this is what you see. iv'e done that already in the past so i can implement it quite easily although its a hard and fancy task :-)

from synology-gitlab-ce.

I also have it almost ready :)

from synology-gitlab-ce.

cool would love to see :-)

from synology-gitlab-ce.

here you go :)
#3

from synology-gitlab-ce.