Giter Club home page Giter Club logo

Comments (2)

jborean93 avatar jborean93 commented on September 28, 2024

Thanks for bringing this up, a thread should definitely be linked to the connection and stopped once the connection is disconnected.

from smbprotocol.

jborean93 avatar jborean93 commented on September 28, 2024

Sorry for the delay but I had another look into this and the threads for each connection will be stopped when you run .disconnect(). In the diconnect() function it calls self.transport.close()

self.transport.close()

Part of closing the transport is to close the socket by sending the shutdown signal, waiting for that thread to finish then finally closing the socket

self._sock.shutdown(socket.SHUT_RDWR)
self._t_recv.join()
self._sock.close()

When the actual socket is shutdown by either the client or the server, it is set to always add None to the connection thread queue

finally:
# Make sure we close the message processing thread in connection.py
self._recv_queue.put(None)

Finally once the recv_queue receives None (the socket has been closed) it exits the process which subsequently stops the thread

b_msg = msg_queue.get()
# The socket will put None in the queue if it is closed, signalling the end of the connection.
if b_msg is None:
return

If you are finding this is not the case on your setup I'm happy to have a further look but it does seem like the thread will be cleaned up when you disconnect from the connection. Even when running a test I found that the only thread still running after calling .disconnect() is the main thread.

from smbprotocol.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.