Noob question about ntp.hosts overriding about ios-ntp HOT 13 OPEN

Feel free to edit your ntp.hosts file to contain the hosts you want.

from ios-ntp.

Hi Gavin!

The problem is when pod is updated (pod update) the changes I did in ntp.hosts will be lost.

from ios-ntp.

Would you want the ntp.hosts removed from the pod? That way it won't get overwritten, but neither will it get added in the first place. If the file is not there, the code deals with that by using a default, built-in list of NTP hosts comprised of the global and continental pools.

I'd be interested in other peoples' thoughts on this to help me decide if this would be OK.

from ios-ntp.

I think you can exclude ntp.hosts file from pod if that doesn't break anything in the logic (which should be true taking into consideration your post above). But I suggest to highlight the opportunity of embedding own ntp.hosts in the README file more clearly.

UPD: By the way, adding some text in README that your repo supports CocoaPods would be a perfection :)

from ios-ntp.

Hi @coffellas-cto!

I think if I exclude ntp.hosts from pod, in the next pod update it will be added again. :/

from ios-ntp.

Nobody is asking for ntp.hosts to be kept in the pod, and removing it will not change the behavior of the library, so I will remove it. I will also, as suggested, improve the README remarks related to this file, and to the fact it supports CocoaPods.

I'll report in this thread when these changes are finished ..

from ios-ntp.

It sounds good! ;)

from ios-ntp.

Done .. "ios-ntp 1.1.1" has been pushed. Let me know if this satisfies.

Notes: If you want to use your own ntp.hosts file, put it in your application main bundle. You may have to remove ntp.hosts from the library files yourself the first time, it won't be refreshed by CocoaPods, but I don't know if it'll be removed either.

from ios-ntp.

Worked like a charm. :)

from ios-ntp.

Is not working anymore. :/
In my tests, the network clock is wrong about few minutes.
I have reviewed your commit multiple times and I didn't found anything weird.
Downgrading solve the problem.

from ios-ntp.

Huh?! Is this with a new ntp.hosts file, or the default time servers? If new, what time server? What does the following command show in Terminal (with your hostname obviously) ?

    sntp -d time.apple.com

from ios-ntp.

I tried default servers (removing ntp.hosts) and ntp.hosts with the same value of the old one.
Very weird.

from ios-ntp.

I'm puzzled too. I've also been promising to audit this code and simplify some details for ages, so it seems I must do that soon. I keep starting these improvements and getting distracted by other projects.

from ios-ntp.