Comments (1)
I agree that the type of a returned variable should match the defined function/method return type but, at least in the case you cite, (1) GCDAsyncUdpSocket.m is code from another library at https://github.com/robbiehanson/CocoaAsyncSocket and that class hasn't been touched for a year, and (2) the function in question (indexOfInterfaceAddr4) is not used anywhere in ios-ntp. The CocoaAsyncSocket code is so widely used that I suspect it is behaving correctly.
Of course, you are not restricted from correcting these type inconsistencies (and maybe pushing your work to Robbie), or from dropping out all the unused functions in your version of the code.
from ios-ntp.
Related Issues (20)
- iOS-ntp returning same value as device HOT 4
- Question for one-time check HOT 4
- Watching possible issue in CocoaAsyncSocket code
- Cocoa Pods released version HOT 1
- Hardcoded NTP Pool names HOT 13
- import error HOT 1
- EXC_BAD_ACCESS HOT 6
- What is missing from RFC 5905 HOT 2
- Grabbing ntpClientRecvTime Twice HOT 1
- Ability to Change the Time Servers Without Reboot
- Account for Packet Loss in One-Off Mode HOT 1
- Any update for cocoapod, version is still 1.1.1 HOT 2
- v1.1.7 updates coming soon .. HOT 1
- when not network to network, error: " dnssd_clientstub deliver_request ERROR:"
- Does not compile because of lacking GCDAsyncUpdSocket HOT 3
- 该网络时间从哪来?
- 有啥用呢? HOT 1
- How to get the accurate network time after modifying the system time HOT 13
- demo clock is wrong HOT 5
- Whether the poll interval can be automatically increase?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ios-ntp.