LOGIN_URL issue about django-two-factor-auth HOT 4 CLOSED

Django-two-factor-auth doesn't require LOGIN_URL to be configured to link to two_factor:login, but it is advised to do so. By doing so, the OTP login flow will be used when a user with OTP enabled tries to login. For users with OTP disabled, there is no additional steps to provide OTP tokens.

Without setting LOGIN_URL, the @otp_required decorator (and the like), will still work. You'll be required however to point them to the correct URL for two_factor:login. Does this solve your question?

from django-two-factor-auth.

In code base at various places this variable is in use settings.LOGIN_URL e.g
class AdminSiteOTPRequiredMixin(object):

def login(self, request, extra_context=None):
"""
Redirects to the site login page for the given HttpRequest.
"""
return redirect('%s?%s' % (
settings.LOGIN_URL,
urlencode({REDIRECT_FIELD_NAME: request.get_full_path()})
))

And as we are using this Login_url for another app so admin OTP decorator redirects towards here. and we just place TWO_FACTOR_PATCH_ADMIN=True in our settings.

from django-two-factor-auth.

You're correct; the code should not use LOGIN_URL, but should've used two_factor:login. I've changed the code in those places. Please try the code from the master branch and let me know if it works for you.

from django-two-factor-auth.

Yeah, it's working as expected now. Thank you for quick fix.

from django-two-factor-auth.