New SMS integration about django-two-factor-auth HOT 7 CLOSED

Thanks for the translation, it's great to see everyone's involvement from all over the world!

Regarding implementing a new gateway, have a look at the Twilio gateway, and most notably the interface of the gateway class. If you implement a class with the signature shown below, it's enough. Depending on how phone calls are made, you might need to wire some Django views and urls, as is also shown in the Twilio gateway. Finally, you can also have a look at the "fake gateway", which also shows an implementation of the gateway.

class MyGateway(object):
    def make_call(self, device, token):
        raise NotImplementedError()

    def send_sms(self, device, token):
        raise NotImplementedError()

Sadly I'm not traveling to DjangoCon this round, but would love to visit some year in the future. Have a great week!

from django-two-factor-auth.

If you have any additional questions, please let me know :).

from django-two-factor-auth.

Hello again @Bouke :)
I've worked on fake.py and sms is now getting sent and working perfectly.

How do i show you my work? paste here or add you to the fork i did to review before submitting pull request?

I based fake.py on another django app which made it work within minutes!

from django-two-factor-auth.

and I believe i need help in testing what i did?

from django-two-factor-auth.

For reviewing your code, you could post it here. I'm not very inclined to add extra gateways, as the burden of supporting it and updating it with API changes would also be mine.

from django-two-factor-auth.

@Bouke actually its a complete ready app so maintaining it is not going to be handled by django-two-factor-auth but django-nexmo

What I did is installed django-nexmo and updated fake.py to the following:

from nexmo import send_message

class Fake(object):
    @staticmethod
    def send_sms(device, token):
        send_message(device.number,'Your token is: %s' % token)

and worked, my next addition is to have django-nexmo supports voice then would add another staticmedhod for make_call to call since Nexmo supports voice too.

from django-two-factor-auth.

That looks like a nice and simple solution. However you could consider renaming the class to NexmoGateway instead of Fake, but looks great otherwise.

from django-two-factor-auth.