Giter Club home page Giter Club logo

Comments (7)

jaytaylor avatar jaytaylor commented on June 2, 2024 1

@matcornic I'm working on a PR for this, may have something later today or if I don't get to it before Friday I'll have some time this weekend.

Once I open the PR I'll select you both as reviewers so we can ensure it's good for everyone :)

Thanks!

cc @MarcGrol

from html2text.

jaytaylor avatar jaytaylor commented on June 2, 2024

Oh no! I'm sorry to hear that we've inadvertently broken you. Appreciate you reaching out in such a timely manner!

I'm confident we can find a way to accommodate all our collective needs in this case.

My first impulse is to add some config options so that we can control the rendering behavior. Perhaps it'd look like an optional extra parameter with a flag to disalbe ASCII table rendering.

Does this sound like a reasonable compromise / approach? Any other ideas on how we can best resolve this issue? I'm all ears! :D

from html2text.

MarcGrol avatar MarcGrol commented on June 2, 2024

Thanks for your response. Your suggested approach would allow me to keep using the latest and greatest version of html2text.

from html2text.

matcornic avatar matcornic commented on June 2, 2024

Hey @MarcGrol,
I'm the one responsible of breaking your usage :(. I agree with @jaytaylor solution.

In my opinion, I think the default behavior should be the old display. And an option like "PrettyTable" could be enabled.

Moreover, this kind of options could be used for example to replace the character used for converting the lists "* vs -"

@MarcGrol do you plan to make the PR or should I do it ?

from html2text.

jaytaylor avatar jaytaylor commented on June 2, 2024

@matcornic @MarcGrol GH currently not letting me request reviews from you, so if you're able please try / check it out and let me know what you think!

Cheers,
Jay

from html2text.

matcornic avatar matcornic commented on June 2, 2024

@jaytaylor looks fine to me, i commented the PR :)

from html2text.

MarcGrol avatar MarcGrol commented on June 2, 2024

Sorry for the delay.
@jaytaylor @matcornic: Reviewed and tested this specific version against my software and everything works fine again.
I am glad I can keep using the latest and greatest version of the html2text package.
Thanks a lot for creating the PR.

from html2text.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.