Comments (2)
Thanks for the suggestions I appreciate it!
Here are my responses:
- I'll consider using brigadier but for now the command system isn't a very high priority.
- Originally I did just generate Java source for the
Items
class, however this caused some issues because Java has limits on how large classes/enums/files can be and since Terraria has ~5000 items that method just wasn't feasible. - I'm open to refactoring if you can point out specific things you think could use changing.
If I'm going to be frank, this project wasn't really meant to become a genuine replacement for the vanilla Terraria server, as that is a lot of work and there's not much need for a rewrite. I mainly did this so I could have some fun messing around with the Terraria protocol (which is absolutely horrible by the way). Despite all this, if there are people that have genuine interest in Pluto and see opportunities for it I'm happy to look into that.
from pluto.
Thanks for your response!
I'll review the source code in the coming weeks, and find something that can be improved.
However, I'm not really good at programming, so it maybe takes some time.
So here is a little advice:
- Logger is supposed to be delivered when creating a new channel handler object instead of accessing it from a static field: https://github.com/jaydevelopsstuff/Pluto/blob/master/src/main/java/net/guardiandev/pluto/network/channel/GeneralChannelHandler.java
- You add a method named "readPacket" in ClientPacket class (I understand your design is that create a client packet object then invoke "readPacket" method), actually you can add a constructor with only one parameter which should be a ByteBuf and create a new instance while receiving a client packet with this constructor by reflecting:
from pluto.
Related Issues (2)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pluto.