Giter Club home page Giter Club logo

Comments (3)

dzikoysk avatar dzikoysk commented on June 2, 2024

The current upgradeContext property is marked as internal - it means that it shouldn't be visible for you in the first place, so as a root cause I'd mark this as a bug, because it's missing the @JvmSynthetic annotation. If we'd like to open that part of the API, it might be good idea to investigate the pros/cons of doing this, because maybe it'd make more sense to expose only some particular functions like e.g. mentioned path() - that's the approach we already use for half of the methods in this class.

from javalin.

LoonyRules avatar LoonyRules commented on June 2, 2024

Ah yeah @tipsy did mention this in Discord but I just forgot to mention that here. Feel free to adjust this to be a Bug then, with another Issue span off discussing the lack of API method for Ws related contexts if that'd how you'd like to manage this? :)

from javalin.

tipsy avatar tipsy commented on June 2, 2024

The current upgradeContext property is marked as internal - it means that it shouldn't be visible for you in the first place, so as a root cause I'd mark this as a bug,

I agree that this is a bug, but unfortunately we can't add this annotation now (the method has been public for years). So I chose feature request rather than bug.

from javalin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.