Giter Club home page Giter Club logo

Comments (6)

tipsy avatar tipsy commented on June 18, 2024 1

The code just assumes if the plugin is not there, it's not relevant to that app, so it skips a block and continues on.

So something like logging, tracing, analytics?

FWIW I'm translating code from Ktor, which has a pluginOrNull function.

I supposed we could have withOrWithout(MyPlugin) (only half-joking 😄)

I'm not a fan of how withOrNull sounds, so maybe your maybeWith or tryWith. Feel free to submit a PR, and we can discuss the naming there.

from javalin.

dzikoysk avatar dzikoysk commented on June 18, 2024 1

Okay, my bad, I was looking at 5.4.3-SNAPSHOT 🤦‍♀️

from javalin.

tipsy avatar tipsy commented on June 18, 2024

Hi @juggernaut0, could you tell us a bit more about your use case? How does the program recover if the plugin is not there?

from javalin.

juggernaut0 avatar juggernaut0 commented on June 18, 2024

I have some utility functions and plugins that are used across several projects, but not every project needs every plugin.

The code just assumes if the plugin is not there, it's not relevant to that app, so it skips a block and continues on.

There's plenty of workarounds like the try-catch, using nullable ctx.attribute to stash some state, (would prefer the more typesafe plugin api), always adding the plugin but configuring it do do nothing sometimes (feels like boilerplate), or making several versions of the functions.

Basically, the idea is augmenting behavior based on a plugin, but not requiring it to be installed.

FWIW I'm translating code from Ktor, which has a pluginOrNull function.

from javalin.

dzikoysk avatar dzikoysk commented on June 18, 2024

Wouldn't it be easier to just cover this with app data?

 // Javalin's key
data class Key<T>(val id: String)

// Define a key
val OptionalMetrics = Key<Metrics?>("optional-metrics")

// Register data
cfg.pvt.appAttributes[OptionalMetrics] // null or not

// Handler
ctx.appData(OptionalMetrics)?.example("abc")

I'm not sure why there's no public register function for app data, so @tipsy may need to clarify this area.

from javalin.

tipsy avatar tipsy commented on June 18, 2024

I'm not sure why there's no public register function for app data, so @tipsy may need to clarify this area.

From https://javalin.io/documentation#app-data:

val app = Javalin.create { config ->
    config.appData(myKey, myValue)
}

from javalin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.