Comments (6)
I completely agree with httpdigest, not giving credit is neither professional nor respectful.
from glm.
Sorry sorry sorry, you are right, I should't have done that!
That's the problem when you are overloaded of work and you copy paste lazily a method surely working just to get a bug fixed (and then for the same laziness you finish to do the same for almost the whole class..) and postpone to give credits or find what the bug was. I did that when I opened that issue about the normalization input vector... I don't know if you remember
However I modified quickly the readme to give you asap credits and put a quick fix at this issue
I'll go tomorrow through the code, because there are also a couple of other methods in the Glm
from joml
Please again sorry, Kai, I really didn't mean to provoke this. I don't know if this has the same meaning in english, but I completely did that in good faith (remember when I contributed a little to joml), with no bad intentions
from glm.
Alright, then. No worries. :) I appreciate your response.
from glm.
Oh nice, I am glad you appreciated :)
I removed some unused methods coming from joml and modified again the readme writing explicitly "Credits:" and listing the joml methods I left there... I'd like to ask you if I may keep those remaining methods until I manage to review with calm the whole class
Ps: let me offer you a drink :p
from glm.
Hey, what's up. Just one thing:
and return the object itself in order to concatenate operations
You don't have to go overboard with credits for API design concepts that no one did invent and should claim credit for. :) Actually, now I feel a bit worried for my first post here.
What I meant with the first post was just about verbatim copying code including the JavaDocs.
I of course certainly do not take credit for simple API design concepts. :)
Cheers,
Kai
from glm.
Hey Kay, sorry for the late reply, yeah you are right
I just felt so guilty that I overreacted :p
Thanks for your message though :)
Have a nice we!
from glm.
Related Issues (6)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from glm.