Giter Club home page Giter Club logo

Comments (12)

jath03 avatar jath03 commented on June 11, 2024

What versions of openrgb-python and openrgb are you using? Can you send screenshots of OpenRGB's software pane on the Information tab from each OS?

from openrgb-python.

shawnc722 avatar shawnc722 commented on June 11, 2024

I've tested with builds from the last week or so on linux and seen the same problem on each. Just built from source of the current master and I'll download the equivalent package on windows. Here's the linux screenshot:
Screenshot from 2021-04-29 01-00-35
Running openrgb-python 0.2.8 on linux, and I'll boot into windows and post the rest ASAP.

from openrgb-python.

shawnc722 avatar shawnc722 commented on June 11, 2024

Here's windows:
image
I didn't realize, but apparently I'm only running openrgb-python 0.2.5 on windows. I'll try updating now and see if it causes the same issue on windows.
Edit: the same version works fine on windows.

from openrgb-python.

jath03 avatar jath03 commented on June 11, 2024

Just to make sure that the version has nothing to do with the issue, can you try forcing v1 on linux?

cli = OpenRGBClient(protocol_version=1)

from openrgb-python.

shawnc722 avatar shawnc722 commented on June 11, 2024

Exact same message using v1, down to the byte that caused the error. I'll try downgrading to openrgb-python 0.2.5 on python to test that.

from openrgb-python.

jath03 avatar jath03 commented on June 11, 2024

Actually, here's a more important question: exactly which OpenRGB commit broke it?

from openrgb-python.

shawnc722 avatar shawnc722 commented on June 11, 2024

Okay I'm getting the same message on 0.2.5, which I was running on the same distro with no issues not very long ago. That's gotta mean the problem is coming from openrgb itself lol.
I haven't narrowed it down to the exact commit yet, but I'll try to do that now.

from openrgb-python.

jath03 avatar jath03 commented on June 11, 2024

I just realized that this looks very similar to #18, and you did recently add a device to OpenRGB. Might this function be returning something weird?

from openrgb-python.

shawnc722 avatar shawnc722 commented on June 11, 2024

Actually just narrowed it down, it stopped working on this commit, which ironically was also to add a device I requested. Thanks for your help!

from openrgb-python.

shawnc722 avatar shawnc722 commented on June 11, 2024

Yep, exactly the same problem as the issue you posted. I'm sorry to bother you for the same thing twice!
Thanks again for all your help.

from openrgb-python.

jath03 avatar jath03 commented on June 11, 2024

I or someone should probably implement @inlart's the solution to #18 across all HID devices in OpenRGB to prevent this from occurring again.

from openrgb-python.

shawnc722 avatar shawnc722 commented on June 11, 2024

Yeah, that's probably a good idea. I just borrowed his solution and recompiled, but it looks like the same problem is actually affecting my keyboard too, which I just added support for a few days ago.
I'll also stop starting my bug hunts over here, after making the issues on your repo when it's not to blame twice in a row lol. Thanks again!
Edit: patched the keyboard files too, and now it works flawlessly again.

from openrgb-python.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.