Giter Club home page Giter Club logo

Comments (2)

callaginn avatar callaginn commented on August 19, 2024

I've noticed a similar issue with vcard photos.

How to Reproduce

INPUT: PHOTO:https://example.com/photo.jpg
OUTPUT: https

Possible Workarounds

You can work around this two different ways:

A) Remove the colon and text before it:

INPUT: PHOTO://example.com/photo.jpg
OUTPUT: //example.com/photo.jpg

B) Add MEDIATYPE information:

INPUT: PHOTO;MEDIATYPE=image/jpeg:https://example.com/photo.jpg
OUTPUT: PHOTO: { type: [ 'MEDIAimage/jpeg' ], value: '//example.com/photo.jpg' }

from node-vcard.

callaginn avatar callaginn commented on August 19, 2024

Possible Fix:

In the this.parsevCard() function of blob/master/vcard.js, change this:

var fields = data[f].split(":");

to this:

var fields = data[f].split(/(?<=^[^:]+):/y);

Basically, they were splitting the string on every single colon and returning the second array item. So stuff like URLs got split multiple times. That regex split makes sure it splits only the first colon.

from node-vcard.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.