Comments (5)
jeremydmiller
commented on August 29, 2024
3
@aradalvand C'mon, this was documented.
"Huge bummer though; this is a deal breaker for a lot of us and it effectively means we couldn't use Marten at all."
That's absolutely and completely bonkers IMO. Why does this even matter, really? Are you wanting that to maybe distinguish between different aggregates?
And just so everybody understands what an insane amount of work it was to add what's already there, check out the commit history for the document db side of this:
I hate all of you. This is so much work for so very, very little value for just a handful of people who desperately love unnecessary complexity. But let's get this done so people stop complaining about it.
from marten.
matthewtamm
commented on August 29, 2024
Check docs @ https://martendb.io/documents/identity.html#strong-typed-identifiers
There is an Info callout re strong identifiers and the event store
…________________________________
From: Arad Alvand (AmirHossein Ahmadi) ***@***.***>
Sent: Thursday, July 11, 2024 4:44:09 PM
To: JasperFx/marten ***@***.***>
Cc: Subscribed ***@***.***>
Subject: [JasperFx/marten] `Id type mismatch` exception when using strongly typed IDs (Issue #3306)
I thought support for this was added following #2487<#2487> but I can't seem to get a pretty simple sample working.
Types.cs:
using System.Text.Json.Serialization;
using Vogen;
namespace Foo;
[ValueObject<Guid>(toPrimitiveCasting: CastOperator.Implicit)]
public readonly partial struct PaymentId;
public class Payment
{
[JsonInclude]
public PaymentId Id { get; private set; }
[JsonInclude]
public DateTimeOffset CreatedAt { get; private set; }
[JsonInclude]
public PaymentState State { get; private set; }
public static Payment Create(PaymentCreated @event) => new()
{
Id = @event.Id,
CreatedAt = @event.CreatedAt,
State = PaymentState.Created,
};
public void Apply(PaymentCanceled @event)
{
State = PaymentState.Canceled;
}
public void Apply(PaymentVerified @event)
{
State = PaymentState.Verified;
}
}
public enum PaymentState
{
Created,
Initialized,
Canceled,
Verified,
}
public record PaymentCreated(
PaymentId Id,
DateTimeOffset CreatedAt
);
public record PaymentCanceled(
PaymentId Id,
DateTimeOffset CanceledAt
);
public record PaymentVerified(
PaymentId Id,
DateTimeOffset VerifiedAt
);
Program.cs:
using Foo;
using Marten;
using Marten.Events.Daemon.Resiliency;
using Marten.Events.Projections;
using Weasel.Core;
var builder = WebApplication.CreateBuilder(args);
builder.Services.AddMarten(options =>
{
options.Connection(
"Host=localhost;Database=marten_event_store_test;Username=arad;Password=1301381"
);
options.UseSystemTextJsonForSerialization(options: new()
{
IncludeFields = true,
});
if (builder.Environment.IsDevelopment())
options.AutoCreateSchemaObjects = AutoCreate.All;
options.Projections.Snapshot<Payment>(SnapshotLifecycle.Inline);
options.Events.AddEventType<PaymentCreated>();
options.Events.AddEventType<PaymentVerified>();
options.Events.AddEventType<PaymentCanceled>();
})
.AddAsyncDaemon(DaemonMode.HotCold)
.UseLightweightSessions();
var app = builder.Build();
var paymentId = PaymentId.From(Guid.Parse("eb5b8626-973f-41f0-922d-4a4303eeb625"));
app.MapGet("/", async (IDocumentSession session) =>
{
var r2 = await session.Events.FetchForWriting<Payment>(paymentId);
return r2.Aggregate;
});
app.MapPost("/", async (IDocumentSession session) =>
{
session.Events.Append(paymentId, new PaymentCreated(
paymentId,
DateTimeOffset.Now
));
session.Events.Append(paymentId, new PaymentCanceled(
paymentId,
DateTimeOffset.Now
));
await session.SaveChangesAsync();
return "done";
});
app.Run();
Upon dotnet run, I get the following exception:
Unhandled exception. Marten.Exceptions.InvalidProjectionException: Id type mismatch. The stream identity type is System.Guid, but the aggregate document Foo.Payment id type is PaymentId
at Marten.Events.Projections.ProjectionOptions.AssertValidity(DocumentStore store)
at Marten.DocumentStore..ctor(StoreOptions options)
at Marten.MartenServiceCollectionExtensions.<>c.<AddMarten>b__8_1(IServiceProvider s)
at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSiteMain(ServiceCallSite callSite, TArgument argument)
at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitRootCache(ServiceCallSite callSite, RuntimeResolverContext context)
at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSite(ServiceCallSite callSite, TArgument argument)
at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitConstructor(ConstructorCallSite constructorCallSite, RuntimeResolverContext context)
at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSiteMain(ServiceCallSite callSite, TArgument argument)
at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitRootCache(ServiceCallSite callSite, RuntimeResolverContext context)
at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSite(ServiceCallSite callSite, TArgument argument)
at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.Resolve(ServiceCallSite callSite, ServiceProviderEngineScope scope)
at Microsoft.Extensions.DependencyInjection.ServiceProvider.CreateServiceAccessor(ServiceIdentifier serviceIdentifier)
at System.Collections.Concurrent.ConcurrentDictionary`2.GetOrAdd(TKey key, Func`2 valueFactory)
at Microsoft.Extensions.DependencyInjection.ServiceProvider.GetService(ServiceIdentifier serviceIdentifier, ServiceProviderEngineScope serviceProviderEngineScope)
at Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceProviderEngineScope.GetService(Type serviceType)
at Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions.GetRequiredService(IServiceProvider provider, Type serviceType)
at Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions.GetRequiredService[T](IServiceProvider provider)
at Marten.MartenServiceCollectionExtensions.MartenConfigurationExpression.<>c.<AddAsyncDaemon>b__8_1(IServiceProvider s)
at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSiteMain(ServiceCallSite callSite, TArgument argument)
at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitRootCache(ServiceCallSite callSite, RuntimeResolverContext context)
at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSite(ServiceCallSite callSite, TArgument argument)
at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitIEnumerable(IEnumerableCallSite enumerableCallSite, RuntimeResolverContext context)
at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSiteMain(ServiceCallSite callSite, TArgument argument)
at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitRootCache(ServiceCallSite callSite, RuntimeResolverContext context)
at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSite(ServiceCallSite callSite, TArgument argument)
at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.Resolve(ServiceCallSite callSite, ServiceProviderEngineScope scope)
at Microsoft.Extensions.DependencyInjection.ServiceProvider.CreateServiceAccessor(ServiceIdentifier serviceIdentifier)
at System.Collections.Concurrent.ConcurrentDictionary`2.GetOrAdd(TKey key, Func`2 valueFactory)
at Microsoft.Extensions.DependencyInjection.ServiceProvider.GetService(ServiceIdentifier serviceIdentifier, ServiceProviderEngineScope serviceProviderEngineScope)
at Microsoft.Extensions.DependencyInjection.ServiceProvider.GetService(Type serviceType)
at Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions.GetRequiredService(IServiceProvider provider, Type serviceType)
at Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions.GetRequiredService[T](IServiceProvider provider)
at Microsoft.Extensions.Hosting.Internal.Host.StartAsync(CancellationToken cancellationToken)
at Microsoft.Extensions.Hosting.HostingAbstractionsHostExtensions.RunAsync(IHost host, CancellationToken token)
at Microsoft.Extensions.Hosting.HostingAbstractionsHostExtensions.RunAsync(IHost host, CancellationToken token)
at Microsoft.Extensions.Hosting.HostingAbstractionsHostExtensions.Run(IHost host)
at Program.<Main>$(String[] args) in /home/arad/scratchpad/marten-vogen-test/Program.cs:line 58
—
Reply to this email directly, view it on GitHub<#3306>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AABRCTPEXOFS3C6YFI2TG73ZLYSTTAVCNFSM6AAAAABKWJ4THKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQYDEMZYHA4DOMA>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
from marten.
mysticmind
commented on August 29, 2024
There is not yet any direct support for strong typed identifiers for the event store
from marten.
aradalvand
commented on August 29, 2024
Ah, okay. Thanks for the pointers. I didn't see that callout.
Huge bummer though; this is a deal breaker for a lot of us and it effectively means we couldn't use Marten at all.
Is there an issue tracking this limitation or could we leave this one open to do so?
from marten.
mysticmind
commented on August 29, 2024
Let us just leave this issue open.
from marten.
Related Issues (20)
- Async Projection skips events HOT 2
- Some kind of server side assertion when trying to append events to an archived stream
- It seems that .ToPagedListAsync() could not be combined with a .Select when using Query<T> HOT 1
- Curious why drop netstandard HOT 1
- Missing repository information in NuGet package HOT 5
- Unable to Load related Entities/Documents Successfully HOT 2
- Bug: IMartenQueryable doesn't work well with Projection. HOT 4
- Include does not work after migrating to v7.26.1 from v6 HOT 16
- Async deamon healthcheck in combination with master table tenancy throws unsupported error HOT 1
- Include and Count does not work together after migrating to V7. HOT 1
- When using paging with an include, Stats.TotalResults is equal to the number of results on the page only instead of the total overall results HOT 4
- Error when using numeric revisioned documents with identity map HOT 1
- Marten is not creating the database in a console application HOT 3
- `DropExisting()` fails with "DROP DATABASE cannot be executed within a pipeline"
- `MaintenanceDatabase(...)` is required for create & drop database operations HOT 3
- Question on FullTextSearch with field containing URL in F# HOT 3
- MetadataToken collisions causing unpredictable Linq query execution when using custom method call parsers HOT 4
- "Sequence contains more than one element" exception when using lambda FirstOrDefaultAsync() rather than explicit Where() HOT 1
- Polly retries not working when getting connection failures. HOT 2
- Query on child collection can't use GIN Index
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from marten.