Comments (3)
Hi thco, that was closed a number of years ago, so I can't remember exactly why I decided to close it but a few things that come to mind are:
- There was no example usage of the new functionality.
- The updated code wasn't sent in a pull request where it is easy to see exactly what changed. Pull requests also allow users to talk about proposed code changes easily.
- I'm not sure the code changes are necessary. A user could more easily add
getCenter
andgetBounds
methods to the geometries' prototype.
I should have stated one or more of these when closing the above issue, so that's my fault. Still, I don't think something like this should be added.
from geojson-google-maps.
Ok. I understand, I guess, it's really better to propose PR than hard readable code like this :)
Since few hours now, I tried this providedd code, and yeah, it's not very complient ... You right, maybe it's better to extend geometries prototype, or make some custom function that will read coordinates and fit map bounds with them.
Thanks for those informations !
I close :)
from geojson-google-maps.
👍
from geojson-google-maps.
Related Issues (16)
- invert HOT 1
- Polygon with hole not showing hole - only boundary HOT 3
- Could be the populating of options of Points in GeometryCollection extended? HOT 1
- Properties of GeometryCollection children not being added to Polygons HOT 6
- No MapCenter or FitBounds feature
- package.json for npm HOT 10
- Just a suggestion: for GeoJson's linear rings in polygons, remove the last vertex
- Event binding doesn't seem to work
- Handle GeometryCollection as a geometry member
- v2 for handling Google Maps -> GeoJSON HOT 2
- hi, I've remake a geojson to gmap based on this project with better api.
- _ccw function doesn't work correctly...
- Problem with adding Multipolygon in GeometryCollection object HOT 9
- Please License Under Something Permissive HOT 3
- 'Donut' geometries missing the holes HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from geojson-google-maps.