Giter Club home page Giter Club logo

Comments (5)

jasonlaska avatar jasonlaska commented on May 27, 2024 3

I've merged a patch for this into the develop branch. Will appear in next release but feel free to pul develop for your more immediate purposes.

from spherecluster.

bdpedigo avatar bdpedigo commented on May 27, 2024 2

I'm having the same error, using spherecluster 0.1.7 from PyPI, and sklearn 0.22. It looks like this issue was created with the upgrade from sklearn 0.21 as I just ran the same code with 0.21 and it ran fine.

I would be happy to look into this and make a PR, if you'd like, just let me know @jasonlaska!

from spherecluster.

jasonlaska avatar jasonlaska commented on May 27, 2024

@bdpedigo a PR would be great!

from spherecluster.

fredia avatar fredia commented on May 27, 2024

@bdpedigo thanks, you have done me a great favor! Looking forward to your PR.

from spherecluster.

joseph-sch avatar joseph-sch commented on May 27, 2024

I second all these comments. In the call to _check_sample_weight, the order of arguments is inconsistent with the function definition.

The call:

sample_weight = _check_sample_weight(X, sample_weight)

For reference, the code of _check_sample_weight:

https://github.com/scikit-learn/scikit-learn/blob/4ad4cc632ec37f7b5e05bde66dd675dd4ef7c545/sklearn/utils/validation.py#L1133

So the sample_weight argument should come first and the X argument should come second.

from spherecluster.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.