Giter Club home page Giter Club logo

Comments (7)

Jason-Bloomer avatar Jason-Bloomer commented on September 23, 2024

The sorting function can be a little tricky - are you certain you're using it correctly?

It sorts based off of the last column clicked in the associated grid. (Row doesn't matter)
The header of the column (the row at the very top with the names of each column) should be highlighted blue to show which one is selected.

If I click the price column and then click sort, it seems to work fine in most cases for me. Sometimes when there is a lot of orders for a single item (like for T1 ores) it can get a little confused, but otherwise I am not seeing this behavior.

Likewise sorting by quantities seems to work fine.

Clicking the Market, Expiration, or Item name columns, should perform an alphabetic sort on whichever column was clicked.
Consequentially, clicking no column at all, will often yield the behavior you are describing.

Do keep in mind that every time you click sort, you will again need to click a column to sort by, and it doesn't do reverse-order.

from duopenmarket.

Jason-Bloomer avatar Jason-Bloomer commented on September 23, 2024

Any updates here? Did the steps I provided assist with the problem, or are you still encountering the issue?

from duopenmarket.

WarBringereq avatar WarBringereq commented on September 23, 2024

from duopenmarket.

Sethcran avatar Sethcran commented on September 23, 2024

I can confirm the original report. Sorting by price or quantity does a lex sort rather than a number sort.

So the following numbers: 100, 11, 200 display in that order, rather than the exxpected: 11, 100, 200.

from duopenmarket.

Jason-Bloomer avatar Jason-Bloomer commented on September 23, 2024

Please verify that you are following the steps I have outlined in my comment pertaining to use of the sorting feature.
If you are following those steps, and things still aren't being sorted correctly, could you please provide a screenshot of this occurring, as well as the item you were sorting orders for when this occurred?
This is not the behaviour I am seeing when following the steps outlined in my comment, as mentioned.

A screenshot of everything working fine on my end. Buy orders sorted by price, Sell orders sorted by quantity, looks good to me.
image

from duopenmarket.

Sethcran avatar Sethcran commented on September 23, 2024

I agree that it works per your directions, but I don't think it's necessarily intuitive.

Specifically, normal expectation would be that clicking the price column sorts that column numerically. It does sort, which makes the sort button not obvious that it does anything.

So I guess I would consider this to be a workaround, and that's fine, but would suggest overloading the sort functionality on column click for price/quantity to perform the action that is done on the sort button click, and then remove the sort button entirely.

from duopenmarket.

Jason-Bloomer avatar Jason-Bloomer commented on September 23, 2024

I agree Sethcran, and I appreciate the feedback. It was a temporary workaround but the time has come to do this properly.

I've just pushed out a series of updates which should address the points you've mentioned here. Sorting should now behave a bit more like you would expect it to.

from duopenmarket.

Related Issues (4)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.