Error on using correct translation about mediacenterjs HOT 5 CLOSED

Hej Adam, thanks for updating and pointing out the issue. Weirdly enough I commited a fix for this recently.

501af6f

Very strange that it did not get picked up. I can see it in the file as well:

https://github.com/jansmolders86/mediacenterjs/blob/master/views/setup.jade#L18

from mediacenterjs.

So

userLang.replace(/-.*/,'');

doesn't actually store the replaced value as the variable. See here. So to fix it, I used

userLang = userLang.replace(/-.*/,'');

from mediacenterjs.

Doh! I totally missed that! Thanks for spotting my mistake. I'll fix it asap. Little sidenote: I was thinking it might be better overall to use a pre-release branch and test things more thoroughly before pushing to master. Do you agree?

from mediacenterjs.

Well, I think on your repo, that would be good, and then merge it into master when you've got something stable working. As far as my fork, I just sync from your repo, fix merge conflicts, then keep working. I'm trying to move all the youtube stuff into the youtube folder so there are not any merge conflicts. If you decide to use a pre-release branch, I can start working on that branch as well with my changes. Or I can make a youtube branch on my fork.

from mediacenterjs.

Thanks for thinking with me on this.I think I want to start working with sprints as soon as the npm manager, the merge conflict from hoffi's merge are fixed and there is better oxs support. that way there will be a more stable master repo for you to work with and sprints will be tested better before merging.

I'll close this issue for now as I just commited the fix. cee3c3a

Thanks again!

from mediacenterjs.