Giter Club home page Giter Club logo

Comments (12)

janosh avatar janosh commented on August 23, 2024

Good points all. Will tackle them as time permits.

from svelte-multiselect.

frederikhors avatar frederikhors commented on August 23, 2024

Tailwind released Comboboxes today! https://tailwindui.com/components/application-ui/forms/comboboxes.

I think we need to be inspired by them.

from svelte-multiselect.

janosh avatar janosh commented on August 23, 2024

They charge money for that? But sure, let's take what good ideas we can from them.

from svelte-multiselect.

frederikhors avatar frederikhors commented on August 23, 2024

They charge money for that? But sure, let's take what good ideas we can from them.

Yes, they do charge. But I don't mean we have to pay. Just get the best out of their work. Inspiration.

from svelte-multiselect.

janosh avatar janosh commented on August 23, 2024

Yes, they do charge. But I don't mean we have to pay. Just get the best out of their work. Inspiration.

I know, I understood that. I'm just surprised people pay £119 for a UI framework.

from svelte-multiselect.

frederikhors avatar frederikhors commented on August 23, 2024

I'm just surprised people pay £119 for a UI framework.

😄

Anyway this is for inspiration too: https://headlessui.dev/react/combobox.

from svelte-multiselect.

frederikhors avatar frederikhors commented on August 23, 2024

Here the svelte version: https://github.com/rgossiaux/svelte-headlessui, the Combobox porting is coming, only the select is available now.

from svelte-multiselect.

janosh avatar janosh commented on August 23, 2024
  1. As you can see from the picture here: the font of the "placeholder" is very bad. Too big compared to other selects I am using right now.
    issue

Just for later reference, this was due to

/* minimum font-size > 16px ensures iOS doesn't zoom in when focusing input */
/* https://stackoverflow.com/a/6394497 */
font-size: calc(16px + 0.1vw);

which was added to stop Safari from zooming in on this component when user focuses the input. People who encounter this problem and want to prevent Safari's zoom behavior will have to increase font size themselves, I guess.

  1. When you select an item and then delete it you can see that the seelct increases in height, even if only by 1px is very annoying.

Can you post a GIF of this? I can't reproduce it.

  1. The rounded border is too much.

Default border-radius changed from 5 to 3 pt.

- border-radius: var(--sms-border-radius, 5pt);
+ border-radius: var(--sms-border-radius, 3pt);
  1. If I click on a label for that select each time I click the dropdown is faded away... I think this is useless.
    issue

This is hard to fix. The component closes itself when it detects the user clicked anywhere outside itself. The form label is outside but then default browser behavior is focus associate input of form label so MultiSelect immediately regains focus and calls setOptionsVisible(true), triggering the animation. We would have to check the click was outside and not on a form label with the same ID. Can be done but seems brittle and asking for trouble.

  1. I would like to have another (more classical) animation for hover on list voices. Not the actual which is not really suitable for those with vision problems because it moves every single item to the right. I think a simple background color on:hover is enough.

I agree. Thought about making this change a few times myself but wasn't quite motivated enough. It's done now.

  1. As you can see in the same gif the gray background is not aligned in the select content.

I think this is fixed already, no? If not could you share another screenshot of what you mean?

from svelte-multiselect.

janosh avatar janosh commented on August 23, 2024

I think #52 fixes all the points here except 5 which I'm marking as wontfix unless someone knows a good way of not triggering focusout callbacks if the click event target is the form label belonging to the input that just lost focus.

@frederikhors If there's anything I missed here besides 4, feel free to open a new issue.

from svelte-multiselect.

frederikhors avatar frederikhors commented on August 23, 2024

You mean 4, right?

from svelte-multiselect.

janosh avatar janosh commented on August 23, 2024

Oops, typo. Yes, I meant 4.

from svelte-multiselect.

janosh avatar janosh commented on August 23, 2024

Changes released in v4.0.1.

from svelte-multiselect.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.