`cloup.Group` ignores `command_class` to produce sub-commands about cloup HOT 9 CLOSED

I can confirm the latest release of Cloup v2.1.2 is addressing this issue.

Thanks again @janluke for the fast release!

from cloup.

Thanks for reporting. I fixed it but I'm having issues with mypy.

from cloup.

Thanks for reporting. I fixed it but I'm having issues with mypy.

Thanks @janluke for the quick update! You're fast!

As for Mypy I guess you shouldn't try to be too perfect. You're better than me at types, but you have to realize the typing you're doing in Cloup is quite advanced. Click itself has some difficulties with typing the latest 8.1.4 release. See: pallets/click#2558

What I wanted to say: it is OK for me to have a couple of # type: ignore[] in the code if it makes your life easier as a maintainer. You'll have time to revisit these issues and perfect it in next releases.

from cloup.

Ah, and see @davidism comment about being reasonable with typing in Click:

Also, note that typing in Python is optional. Click is not broken by this, 8.1.4 works just fine and fixes a lot of issues. You have the power to ignore any typing errors that are not useful, either inline, per file, or across a project if you need to get CI to pass. It's ok, you're not suddenly going to write the decorator wrong 😉.

from cloup.

I've always considered typing (and good IDE autocompletion) a feature of Cloup. If I use cloup.group, then I expect my IDE knows I can call section(). Unfortunately, Click is not designed with typing in mind.

from cloup.

Actually, even master fails mypy checks now: https://github.com/janluke/cloup/actions/runs/5542413108/jobs/10117062431

from cloup.

Actually, even master fails mypy checks now: https://github.com/janluke/cloup/actions/runs/5542413108/jobs/10117062431

Yeah probably because of click==8.1.4.

To catch regression as fast as possible and reduce the maintenance overhead, I:

• Run tests every week
• Test against Click 8.1.x branch and main (i.e. the upcoming 8.2.x branch)
• Test against Cloup stable and master release

That way I can fix or report issues quickly, before they compounds.

from cloup.

I checked the click issue only a few minutes ago, I hadn't understood that click 8.1.4 was the cause of the issue. So, I'll fix this issue when I have time, maybe after work today.

Yes, I'll add weekly tests as well.

from cloup.

I think your issues are being addressed by Click 8.1.5 which was released 40 minutes ago.

from cloup.