Discussion: Jan to fully adopt Clean Architecture about jan HOT 3 CLOSED

According to TCA, there is no need to provide the @janhq/common module. Common will encompass all Use Cases, containing only the business logic without any 3rd-party framework imports; the repository framework will be injected automatically. The structure above represents the correct version.

@linhtran174 is relocating /common to /core/common. The file system framework will be injected by the application (web/node), for example, via the global object.

from jan.

@louis-jan There's no janhq/common module. It is just a folder to contain base definitions - it doesn't export. Actual modules like assistant or threat implements the base interface and then is actually exported. It's just a code organization point.

I'm gonna close this disc bc:

1. It's a outdated / incorrect in some parts
2. You've already done parts of it
3. I'll be creating separate discussions on remaining questions

from jan.

I have refactored this to be part of #729. Will be removing it from Roadmap view

from jan.