I'm working on the testing chapter of Real World OCaml, and it highlights that using <

I have a couple of changes under review to go from: <div class="snippet-clipboard-

This change landed in <a class="commit-link" data-hovercard-type="commit" data-hoverca

Exception-based error reporting is noisy about ppx_inline_test HOT 4 CLOSED

janestreet commented on September 9, 2024

Exception-based error reporting is noisy

from ppx_inline_test.

Comments (4)

sliquister commented on September 9, 2024

It's hard to line up the positions of these stack traces with the actual source code, but it should be fixable. I think it's a matter of capturing exceptions directly from the user code, whereas right now there are things like Exn.protect in between the user code and the try with.

from ppx_inline_test.

sliquister commented on September 9, 2024

I have a couple of changes under review to go from:

File "source.ml", line 41, characters 0-75: rev threw
(runtime.ml.E "comparison failed"
  ((1 2 3) vs (3 2 1) (Loc sourcelib/source.ml:42:13))).
  Raised at Ppx_assert_lib__Runtime.failwith in file "runtime.ml" (inlined), line 28, characters 28-53
  Called from Ppx_assert_lib__Runtime.fail_in_sexp_style in file "runtime.ml" (inlined), line 48, characters 2-23
  Called from Ppx_assert_lib__Runtime.test_eq_failed in file "runtime.ml", line 85, characters 2-107
  Called from Ppx_inline_test_lib__Runtime.test_unit.(fun) in file "runtime.ml", line 513, characters 15-19
  Called from Base__Exn.protectx in file "exn.ml" (inlined), line 66, characters 8-11
  Called from Base__Exn.protect in file "exn.ml", line 77, characters 26-49
  Re-raised at Base__Exn.protectx in file "exn.ml" (inlined), line 71, characters 4-114
  Called from Base__Exn.protect in file "exn.ml", line 77, characters 26-49
  Called from Ppx_inline_test_lib__Runtime.time_and_reset_random_seeds in file "runtime.ml" (inlined), line 365, characters 15-52
  Called from Ppx_inline_test_lib__Runtime.test in file "runtime.ml", line 460, characters 53-84

to:

File "source.ml", line 41, characters 0-75: rev threw
(runtime.ml.E "comparison failed"
  ((1 2 3) vs (3 2 1) (Loc sourcelib/source.ml:42:13))).
  Called from Ppx_assert_lib__Runtime.test_eq in file "runtime.ml", line 85, characters 2-107
  Called from Sourcelib__source.(fun) in file "source.ml", line 42, characters 13-21

which I think is as good as it can get.

from ppx_inline_test.