Failed to work in cloudflare workers esm mode about jsquash HOT 8 CLOSED

Thank you! I haven’t try yet. But I found an issue in example that Cloudflare workers ESM mode spent not support wasm in wrangler.toml anymore.

Use direct import instead

// @ts-ignore
import PNG_DEC_WASM from '../../node_modules/@jsquash/png/codec/squoosh_png_bg.wasm';
// @ts-ignore
import WEBP_ENC_WASM from '../../node_modules/@jsquash/webp/codec/enc/webp_enc_simd.wasm';

from jsquash.

Maybe you could mention that in readme.md

from jsquash.

It looks like my previous changes still work with the ESM Format 🙌

Thanks for your suggestions @rwv

• I've added a new example folder for the esm format
• Also updated the root README with a specific section about using the modules in CloudFlare workers

Maybe you can import wasm directly in jSquash package and user don’t have to run initWASM manually.

Unfortunately I don't think we can. You cannot import "wasm" files directly in JavaScript. Cloudflare is cheating a little bit by allowing non-JS files to be imported, like wasm and html with their bundler. This improves the developer experience but makes the files invalid JavaScript files.

If you don't mind, I'll close this issue now. If you're still encountering issues feel free to re-open. Thanks again!

from jsquash.

workaround:

return moduleFactory({
  // Just to be safe, don't automatically invoke any wasm functions
  noInitialRun: true,
  instantiateWasm,
  locateFile: (url: string) => {
    return url;
  },
});

from jsquash.

Thanks for reporting this @rwv, I've published a new version that I think will fix this.

Can you try npm install -S @jsquash/[email protected] and see if that resolves the issue?

from jsquash.

Thanks for the feedback! Once I confirm I'll add. It seems to working for me locally with wrangler v3 but perhaps I am not properly in ESM mode.

from jsquash.

Ah I see the ESM mode is very different from the Service worker mode. I'll need to make additional changes.

Apologies I misunderstood the problem.

from jsquash.

Maybe you can import wasm directly in jSquash package and user don’t have to run initWASM manually. Although this may affect current users.

from jsquash.