Comments (10)
macfanatic
commented on July 18, 2024
@silasj - What version of PM are you using? On master, this appears to be working, and I just added tests for this scenario in a PR.
from promotion.
jamonholmgren
commented on July 18, 2024
It looks like it's failing when the screen is used in a split_screen. Investigating.
from promotion.
jamonholmgren
commented on July 18, 2024
Hm, can't get it to fail in specs.
from promotion.
silasjmatson
commented on July 18, 2024
This is also in a subclass of a subclass of a Formotion::FormController, where the first subclass includes ProMotion::ScreenModule :p
from promotion.
rbrant
commented on July 18, 2024
Looks like this commit:
may have undone the title fix for when your class inherits from PM::FormotionScreen.
Being only a few days into using both Promotion and Formotion, I may take a crack at a fix but I'm not sure how well it will go :).
from promotion.
jeanmartin
commented on July 18, 2024
Yep, this is broken again. :(
from promotion.
markrickert
commented on July 18, 2024
Jan, are the tests broken? If not, can you write a test that fails?
from promotion.
jeanmartin
commented on July 18, 2024
Gladly: jeanmartin@cb880f8
It's in the version-1.0 branch of my fork.
(I had to require formotion of course)
from promotion.
jamonholmgren
commented on July 18, 2024
Thanks @jeanmartin ... Will look at this soon.
from promotion.
jamonholmgren
commented on July 18, 2024
Confirmed issue.
from promotion.
Related Issues (20)
- Unable to position a TableView by using frame style HOT 4
- ProMotion lifecycle methods running out of order HOT 1
- Unable to add remote image to nav_bar button HOT 3
- Switching to Screen if already open HOT 2
- How to scroll TableScreen to bottom programatically? HOT 2
- Change tab_bar backgroundcolor HOT 2
- Remote images not showing on first load of Table Screen HOT 3
- use custom class for open_tab_bar HOT 1
- Image picker crashes in iOS10 HOT 1
- 'live' and 'pm_live' don't work anymore with version 4.13 HOT 10
- app delegate methods never called HOT 2
- Error can't convert CommentScreen into String (TypeError) HOT 5
- CollectionScreen crashes after reloading data HOT 1
- Cynical dependencies HOT 3
- Circular dependencies on High Sierra HOT 11
- search_text no longer works
- uninitialized constant ProMotion::UITabBarController (NameError) HOT 6
- Regression: WebScreen synchronous javascript execution
- Regression (or simply failing test): table screen `on_reuse` is not called after scrolling
- Ruby 2.6 deprecations removed in Ruby 2.7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from promotion.