Pull to refresh in Table Screen about promotion HOT 37 CLOSED

I like the idea, and have implemented in my own projects with a few lines of code before as well.

I would rather use snake cased method name and the ability to pass a block when the user pulls down on the control to begin the update itself.

class SettingsScreen < PM::TableScreen

  pull_to_refresh # no options just turns the feature on

  # have the block respond to the UIControlEventValueChanged event
  pull_to_refresh do |control|
    # interact with your API possibly?
  end

  # optionally, pass a symbol to call a method instead of a block
  pull_to_refresh :update_data_from_server

end

from promotion.

I like your syntax of your proposition.
I have a question : what's the value of the control variable in the pull_to_refresh do |control| ?

And what about the portability of that feature ? Do you think we can do that if the base deployment target of Promotion is 5.0 ?

from promotion.

control would be the same as self.refreshControl in iOS6, and possibly even in iOS5 from looking at the documentation from CKRrefreshControl, although I'm not sure. Either way, when observing an UIControlEventValueChanged event you can access the object that sent the event, and that's what I would pass along here as control.

Regarding iOS5 compatibility, I don't see why this wouldn't work - the implementation details would have to deal with that, but for the end PM user, I don't think they would ever know it was going on, as it should be.

from promotion.

Ok thanks for the information for the UIControlEventValueChanged

Yeah I think you're right for the iOS 5.

It could be a very nice feature I think !

from promotion.

We implemented pull-to-refresh with the PHFRefreshControl pod in our latest app, but I agree that the iOS 6 version would be useful built-in to PM. CKRefreshControl says "100% API-compatible with UIRefreshControl in iOS 6" so that would work.

Would we automatically include the CKRefreshControl pod in ProMotion? I'm not sure that's possible yet with RubyMotion gems.

from promotion.

I think so solution would be to have that kind of code in the base of PM (I find it in the Joybox project) :

unless defined?(Motion::Project::Config)
  raise "The ProMotion gem must be required within a RubyMotion project Rakefile."
end

Motion::Project::App.setup do |app|
  ...
  app.pods do
    pod 'CKRefreshControl'
  end
end

from promotion.

I just did this with my latest gem, although there is a bug that I filed with motion-cocoapods that requires the user to specify the pod in their rake file, as you can currently only successfully call "app.pods" once (contrary to all the docs).

from promotion.

Planned for 0.6.0.

from promotion.

Here's the before mentioned bug in motion-cocoapods where you can't call app.pods more than once in an entire project.

from promotion.

Is there a way to to do this with the current ProMotion::TableScreen ?

from promotion.

Yes. See my implementation here:
https://github.com/Skookum/RubyMotionTalk/blob/master/RedditRss/app/Screens/RedditRssViewController.rb

from promotion.

Hah @markrickert! I somehow found that right after I posted, copied the implementation, and it works great. Thanks.

from promotion.

Yeah, I posted it to the RubyMotion google group earlier this evening
as an example of what you can do with RubyMotion. Frankly I'm pretty
impressed with myself that I wrote a reddit RSS feed reader in like 50
lines of code, lol

from promotion.

Ah! That's where I found it. Thanks again.

from promotion.

👍 No worries. Glad to help.

from promotion.

Your implementation looks pretty nice, Mark!

from promotion.

Credit goes to @tkadauke for the implementation in his TinyMon client - https://github.com/tkadauke/TinyMon/blob/e12bfef41dae802498fba6f268108d2405a414bf/lib/mixins/refreshable.rb

I just implemented it inline with my view controller. Thanks, Thomas! ...you open sourcing your app was a great help to me!

from promotion.

I'm going to try and work on implementing this. I think that it would work just like the remote images in that if you're on ios <6, you'd have to include the pod in your main Rakefile otherwise it simply wont work (just like the SDWebImage dependency)

from promotion.

👍

from promotion.

Hey everyone, check out my initial work for a refreshable tableview here: https://github.com/markrickert/ProMotion/tree/version-0.6-table-refreshable

I also added some documentation on how to use it: https://github.com/markrickert/ProMotion/tree/version-0.6-table-refreshable#tablescreen

Let me know you're initial thoughts.

TODO:

1. Make it work on iOS < 6.0
2. Better block handling?

from promotion.

Looks really good! I like the refreshable name.

I do have some feedback on this. I think we should be able to specify the method to call in the refreshable specification.

class IndexScreen < PM::TableScreen
  refreshable :pull_data_from_server

  def pull_data_from_server
    some_async_call do
      end_refreshing
      update_table_data # Should this be called implicitly by `end_refreshing`?
    end
  end  

  # ...
end

If you don't pass in a method name, call on_refresh by default. So your method definition could be:

  def refreshable(callback = :on_refresh)
    # ...
  end

from promotion.

For < iOS 6, we can just let devs know to include the CKRefreshControl CocoaPod and it'll work.

from promotion.

Cool. i'll update my code some this evening. Then I have to write tests for it 😉

from promotion.

A sample screen, a little more fleshed out:

class IndexScreen < PM::TableScreen
  searchable placeholder: "Search items"
  refreshable

  def on_refresh
    Item.pull_from_server_async do |items|
      end_refreshing
      @items = items
      update_table_data
    end
  end

  def on_load
    start_refreshing
  end

  def table_data
    [{ cells: @items.map { |item| cell_for_item(item) } }]
  end
end

Something like that.

from promotion.

OK, I think it's about done from an implementation standpoint other than ios5 support.

https://github.com/markrickert/ProMotion/commit/5a57ab6005d15d77b5e81ec4943719556a381e6b

you can just cal refreshable or you can do the balls-to-the-wall customization like this:

refreshable(
  callback: :on_refresh,
  pull_message: "Pull to refresh", 
  refreshing: "Refreshing data…", 
  updated_format: "Last updated at %s", 
  updated_time_format: "%l:%M %p"
)

As you can see, even the text and time format displayed are customizable :)

from promotion.

Also just implemented a warning if the user doesn't define the callback method in their class. https://github.com/markrickert/ProMotion/commit/45d726133cb6e9527d587b383b4f0eac4cd670b9

Last thing to go: ios5 support.

from promotion.

OK, i believe this thing is feature complete... just gotta write some tests and a pull request will be coming your way!

from promotion.

Anyone want to help on the tests? I'm stuck and for some reason can't get the table screen data to load into the spec, so when I try and get views or tap cells, it doesn't work :(

https://github.com/markrickert/ProMotion/blob/version-0.6-table-refreshable/spec/table_screen_spec.rb

When i run rake spec, the simulator doesn't show the cells in the tableview. Wondering if someone with more testing experience might be able to figure it out

from promotion.

I'll help -- I'm working on ProMotion right now and your PR is one of the last things before releasing 0.6. Can you just submit your PR right now? Do it to the 0.6 branch.

from promotion.

Oh, can you include a (non "sonofabitch") version of your screenshot in the README? I really want to include more screenshots for features.

from promotion.

haha... that was just an example screen shot for the discussion thread. I'm not planning on putting a screenshot of the pull to refresh in the readme :)

from promotion.

PR submitted. Thanks for the help & guidance on this! I'm glad to have made an impact on 0.6!

from promotion.

Yeah, I know :D -- but I really want more screenshots in the README at some point. I'm not sure people realize everything ProMotion can do.

from promotion.

Ahh... I misrread the comentt.

Yeah, i can use the default table stuff and include it with a ss of the refresh controller.

from promotion.

Here's a few screenshots:

And here's a super fancy gif for you ;)

from promotion.

Nice! I'll pull it into the README before launching 0.6.

from promotion.

It surprisingly hard to get a screenshot of the pull to refresh menu in a transitioning state... I wound up having to record a video and then extract the image, lol.

from promotion.